linuxserver / docker-smokeping

GNU General Public License v3.0
347 stars 95 forks source link

[BUG] Perl Module for TacacsPlus Probe missing #156

Closed filou01 closed 1 year ago

filou01 commented 1 year ago

Is there an existing issue for this?

Current Behavior

The Smokeping Probe TacacsPlus, which comes with the default installation, does not work because there is a perl module missing. As this Authen::TacacsPlus is not inside the alpine apk registry it has to be installed via cpan (steps below):

apk add perl-app-cpanminus apk add make apk add gcc apk add libc-dev apk add perl-dev cpanm Authen::TacacsPlus

Could you please add these Steps to the Dockerfile as you did with the Auth Radius module in the past?

Expected Behavior

TacacsPlus Probes should be able to resolve all dependencies and work

Steps To Reproduce

add following to Probes section:

Environment

- OS:
- How docker service was installed:

CPU architecture

x86-64

Docker creation

podman run -d   --name=smokeping  -e TZ=Europe/Vienna  -p 1.2.3.4:8080:80   -v /data/smokeping/config:/config:Z   -v /data/smokeping/data:/data:Z  linuxserver/smokeping

Container logs

require Smokeping::probes::TacacsPlus failed: Can't locate Authen/TacacsPlus.pm in @INC (you may need to install the Authen::TacacsPlus module) (@INC contains: .. /usr/share/smokeping /usr/local/lib/perl5/site_perl /usr/local/share/perl5/site_perl /usr/lib/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib/perl5/core_perl /usr/share/perl5/core_perl) at /usr/share/smokeping/Smokeping/probes/TacacsPlus.pm line 18, <$fh> line 95.
BEGIN failed--compilation aborted at /usr/share/smokeping/Smokeping/probes/TacacsPlus.pm line 18, <$fh> line 95.
Compilation failed in require at (eval 98) line 1, <$fh> line 95.
require Smokeping::probes::TacacsPlus failed: Can't locate Authen/TacacsPlus.pm in @INC (you may need to install the Authen::TacacsPlus module) (@INC contains: .. /usr/share/smokeping /usr/local/lib/perl5/site_perl /usr/local/share/perl5/site_perl /usr/lib/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib/perl5/core_perl /usr/share/perl5/core_perl) at /usr/share/smokeping/Smokeping/probes/TacacsPlus.pm line 18, <$fh> line 95.
BEGIN failed--compilation aborted at /usr/share/smokeping/Smokeping/probes/TacacsPlus.pm line 18, <$fh> line 95.
Compilation failed in require at (eval 98) line 1, <$fh> line 95.
require Smokeping::probes::TacacsPlus failed: Can't locate Authen/TacacsPlus.pm in @INC (you may need to install the Authen::TacacsPlus module) (@INC contains: .. /usr/share/smokeping /usr/local/lib/perl5/site_perl /usr/local/share/perl5/site_perl /usr/lib/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib/perl5/core_perl /usr/share/perl5/core_perl) at /usr/share/smokeping/Smokeping/probes/TacacsPlus.pm line 18, <$fh> line 95.
BEGIN failed--compilation aborted at /usr/share/smokeping/Smokeping/probes/TacacsPlus.pm line 18, <$fh> line 95.
Compilation failed in require at (eval 98) line 1, <$fh> line 95.
require Smokeping::probes::TacacsPlus failed: Can't locate Authen/TacacsPlus.pm in @INC (you may need to install the Authen::TacacsPlus module) (@INC contains: .. /usr/share/smokeping /usr/local/lib/perl5/site_perl /usr/local/share/perl5/site_perl /usr/lib/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib/perl5/core_perl /usr/share/perl5/core_perl) at /usr/share/smokeping/Smokeping/probes/TacacsPlus.pm line 18, <$fh> line 95.
BEGIN failed--compilation aborted at /usr/share/smokeping/Smokeping/probes/TacacsPlus.pm line 18, <$fh> line 95.
Compilation failed in require at (eval 98) line 1, <$fh> line 95.
thespad commented 1 year ago

Once https://github.com/linuxserver/docker-smokeping/pull/157 is built can you please test the image and see if it resolves the issue for you.

filou01 commented 1 year ago

Thank you... please help me with the docker run command. I don´t know how to directly access the dockerfile generated from the branch with the docker run command... i´ve tried linuxserver/smokeping/tacacs without success,.. also tried linuxserver/smokeping:tacacs without success... Thanks in advance... Regards, Christoph

Roxedus commented 1 year ago

Change linuxserver/smokeping to lspipepr/smokeping:2.8.2-r2-pkg-1798e1ea-dev-a0e0d91757f75910ed450524ace8dc90c7d1a0d9-pr-157

filou01 commented 1 year ago

Hi, the Tacacs Integartion works well... Could you please merge this branch into the main branch?