search

linuxserver / docker-smokeping

GNU General Public License v3.0
347 stars 95 forks source link

Add instructions to reload the configuration #160

Closed DeflateAwning closed 10 months ago

DeflateAwning commented 10 months ago

Fixes #131. Instructions came from this comment in #131.

LinuxServer-CI commented 10 months ago
I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r2-pkg-8c701655-dev-caa880f8457304c793c1f95759f211694831c833-pr-160/index.html https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r2-pkg-8c701655-dev-caa880f8457304c793c1f95759f211694831c833-pr-160/shellcheck-result.xml Tag Passed
amd64-2.8.2-r2-pkg-8c701655-dev-caa880f8457304c793c1f95759f211694831c833-pr-160 ✅
arm64v8-2.8.2-r2-pkg-8c701655-dev-caa880f8457304c793c1f95759f211694831c833-pr-160 ❌
DeflateAwning commented 10 months ago

Don't merge quite yet; still figuring out the best way to do this actually. The way in this PR is sub-optimal.

LinuxServer-CI commented 10 months ago
I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r2-pkg-8c701655-dev-8bea3d1ad908e4aac3803d357399f91134311109-pr-160/index.html https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r2-pkg-8c701655-dev-8bea3d1ad908e4aac3803d357399f91134311109-pr-160/shellcheck-result.xml Tag Passed
amd64-2.8.2-r2-pkg-8c701655-dev-8bea3d1ad908e4aac3803d357399f91134311109-pr-160 ✅
arm64v8-2.8.2-r2-pkg-8c701655-dev-8bea3d1ad908e4aac3803d357399f91134311109-pr-160 ❌
DeflateAwning commented 10 months ago

Confirmed that this current method is good to merge to main/master! Hopefully somone can review it!

thespad commented 10 months ago

Please replace $CID with smokeping (you can leave the note about replacing it with the name of your container), because 90% of our users will both use the default name and blindly copy/paste whatever is written in the readme.

Otherwise I'm happy to merge it.

DeflateAwning commented 10 months ago

FIxed! Changed $CID to smokeping.

LinuxServer-CI commented 10 months ago
I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r2-pkg-8c701655-dev-931e521a830680bef8509681ad6f2c0ffe797b87-pr-160/index.html https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r2-pkg-8c701655-dev-931e521a830680bef8509681ad6f2c0ffe797b87-pr-160/shellcheck-result.xml Tag Passed
amd64-2.8.2-r2-pkg-8c701655-dev-931e521a830680bef8509681ad6f2c0ffe797b87-pr-160 ✅
arm64v8-2.8.2-r2-pkg-8c701655-dev-931e521a830680bef8509681ad6f2c0ffe797b87-pr-160 ❌