linuxserver / docker-smokeping

GNU General Public License v3.0
347 stars 95 forks source link

favicon missing from basepage.html ? #163

Closed luckman212 closed 6 months ago

luckman212 commented 10 months ago

Is there an existing issue for this?

Current Behavior

When I deploy this docker-smokeping image, the container does not contain the latest basepage.html, with a favicon.

This is a minor issue, but helps to quickly identify the site in bookmarks or open tabs, so is genuinely useful.

I have noticed this behavior for several months, and as of the latest release 2.8.2-r2-ls66

screenshot_LFcqtGbM

vs (where I hand-edited the file to add the base64 encoded favicon from this commit)

image

Steps To Reproduce

  1. deploy docker image
  2. visit page
  3. inspect icon...

Environment

- OS: Ubuntu 22.04.3
- Docker installed via snap

CPU architecture

x86-64

Docker creation

docker run -d \
--name smokeping \
-p 8080:80 \
-v /var/snap/docker/common/var-lib-docker/volumes/smokeping/config:/config \
-v /var/snap/docker/common/var-lib-docker/volumes/smokeping/data:/data \
-v /var/snap/docker/common/var-lib-docker/volumes/smokeping/cache:/var/cache/smokeping \
-e TZ='America/New_York' \
linuxserver/smokeping
github-actions[bot] commented 10 months ago

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

luckman212 commented 9 months ago

Hello, is this issue being rejected? I saw the comment about it being invalid but I believe I have provided all the necessary info.

I updated to the 2.8.2-r2-ls70 tag but the issue remains.

j0nnymoe commented 9 months ago

Smokeping haven't cut a release since August 2021 and that looks like it was added 11 months ago.

LinuxServer-CI commented 8 months ago

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 5 months ago

This issue is locked due to inactivity