linuxserver / docker-smokeping

GNU General Public License v3.0
346 stars 95 forks source link

[BUG] TCPPing Timeout does display 255ms instead of loss #164

Closed filou01 closed 11 months ago

filou01 commented 11 months ago

Is there an existing issue for this?

Current Behavior

in the current used tcpping version a loss is displayd as 255ms reply time. I´ve found out that the combination of the elder shipped tcptraceroute version of busybox and the currently used tcpping V1.7 combination does not work. The latest tcpping 2.5 also does not work, because this does not use tcptraceroute but uses traceroute what leads to problems.

The easiest solution i found out that works as expected is to use tcpping v1.8 instead of v1.7. I´ve downloaded it inside the running container and tested it carefully The source is here: https://github.com/deajan/tcpping/blob/original-1.8/tcpping

Please include it in the docker image instead of the currently included version 1.7

There was another bug report in the past with the same problem and without a solution - now i told you the solution. https://github.com/linuxserver/docker-smokeping/issues/65

The path to the file that needs to be replaced is: https://github.com/linuxserver/docker-smokeping/blob/master/root/defaults/tcpping

regards, Christoh

Expected Behavior

No response

Steps To Reproduce

create a tcpping probe that times out and see the graph

Environment

- OS:
- How docker service was installed:

CPU architecture

x86-64

Docker creation

-

Container logs

-
thespad commented 11 months ago

I don't have a problem with adding the non-busybox traceroute to the container as an alternative.

filou01 commented 11 months ago

Ok, but i didn‘t test the latest version 2.5 in combination with another traceroute version. I think the easiest way is to inplement 1.8 of tcpping instead of 1.7, than all the tcpping probes used by smokepings TCPPing.pm module work as expected without any further modification of the container base. Von meinem iPhone gesendetAm 29.11.2023 um 16:54 schrieb Adam @.***>: I don't have a problem with adding the non-busybox traceroute to the container as an alternative.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

thespad commented 11 months ago

Please can you test lspipepr/smokeping:2.8.2-r2-pkg-2558f655-dev-9d4899863a2bf2b32f523c2cb92cd7944003d9d6-pr-165

filou01 commented 11 months ago

Thank you... Tested successfully in our productive environment. Also the other probes are still working without any troubes. From my point of view it could be merged into the master branch.

Thank you very much!