linuxserver / docker-smokeping

GNU General Public License v3.0
346 stars 95 forks source link

Add configuration for running smokeping in slave mode #170

Closed jkossis closed 7 months ago

jkossis commented 8 months ago

linuxserver.io



Description:

This change adds configuration (via environment variables) that allows for smokeping to be run in slave mode.

Benefits of this PR and context:

Running smokeping in slave mode has its advantages, as you can define configuration that is the source-of-truth on the master host, and replicate it across different machines throughout your network. This can help tease out latency issues that may be unique to certain segments of the network.

How Has This Been Tested?

This has been tested locally on my network. I built and ran the docker image locally on my slave host (raspberry pi 4b running on ubuntu server 22.04). Everything works as expected.

You just need to modify the slaves, targets, and slavessecrets file on the master host, per the documentation.

Source / References:

LinuxServer-CI commented 8 months ago
I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r3-pkg-5477ff02-dev-7bfc188469a7fcadc1ad81a771e55f9e5f744e23-pr-170/index.html https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r3-pkg-5477ff02-dev-7bfc188469a7fcadc1ad81a771e55f9e5f744e23-pr-170/shellcheck-result.xml Tag Passed
amd64-2.8.2-r3-pkg-5477ff02-dev-7bfc188469a7fcadc1ad81a771e55f9e5f744e23-pr-170
arm64v8-2.8.2-r3-pkg-5477ff02-dev-7bfc188469a7fcadc1ad81a771e55f9e5f744e23-pr-170
LinuxServer-CI commented 8 months ago
I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r3-pkg-5477ff02-dev-cdc76873b9413f585121e454bd998ea3a6731e6a-pr-170/index.html https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r3-pkg-5477ff02-dev-cdc76873b9413f585121e454bd998ea3a6731e6a-pr-170/shellcheck-result.xml Tag Passed
amd64-2.8.2-r3-pkg-5477ff02-dev-cdc76873b9413f585121e454bd998ea3a6731e6a-pr-170
arm64v8-2.8.2-r3-pkg-5477ff02-dev-cdc76873b9413f585121e454bd998ea3a6731e6a-pr-170
LinuxServer-CI commented 8 months ago
I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r3-pkg-5477ff02-dev-aae8f6505ce69e117a2e983bd51ac74ba6f4d922-pr-170/index.html https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r3-pkg-5477ff02-dev-aae8f6505ce69e117a2e983bd51ac74ba6f4d922-pr-170/shellcheck-result.xml Tag Passed
amd64-2.8.2-r3-pkg-5477ff02-dev-aae8f6505ce69e117a2e983bd51ac74ba6f4d922-pr-170
arm64v8-2.8.2-r3-pkg-5477ff02-dev-aae8f6505ce69e117a2e983bd51ac74ba6f4d922-pr-170
LinuxServer-CI commented 8 months ago
I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r3-pkg-5477ff02-dev-0adb3400bb0461030ff3e1e98f07cee1bbe18cf9-pr-170/index.html https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r3-pkg-5477ff02-dev-0adb3400bb0461030ff3e1e98f07cee1bbe18cf9-pr-170/shellcheck-result.xml Tag Passed
amd64-2.8.2-r3-pkg-5477ff02-dev-0adb3400bb0461030ff3e1e98f07cee1bbe18cf9-pr-170
arm64v8-2.8.2-r3-pkg-5477ff02-dev-0adb3400bb0461030ff3e1e98f07cee1bbe18cf9-pr-170
jkossis commented 8 months ago

@thespad @thelamer any chance I could get a review on this? 🙂

jkossis commented 7 months ago

@thespad I updated the changelog, I appreciate you getting back to me on this.

LinuxServer-CI commented 7 months ago
I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r3-pkg-c4afba77-dev-8baba958c68a1f83fbbe15e66f40eb4af7d94c7e-pr-170/index.html https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r3-pkg-c4afba77-dev-8baba958c68a1f83fbbe15e66f40eb4af7d94c7e-pr-170/shellcheck-result.xml Tag Passed
amd64-2.8.2-r3-pkg-c4afba77-dev-8baba958c68a1f83fbbe15e66f40eb4af7d94c7e-pr-170
arm64v8-2.8.2-r3-pkg-c4afba77-dev-8baba958c68a1f83fbbe15e66f40eb4af7d94c7e-pr-170