linuxserver / docker-smokeping

GNU General Public License v3.0
347 stars 95 forks source link

Added DNS lookups via `dig` in default setup #92

Closed jandahl closed 4 years ago

jandahl commented 4 years ago

linuxserver.io


We welcome all PR’s though this doesn’t guarantee it will be accepted.

Description:

Benefits of this PR and context:

How Has This Been Tested?

Source / References:

LinuxServer-CI commented 4 years ago

I am a bot, here are the test results for this PR: https://lsio-ci.ams3.digitaloceanspaces.com/lspipepr/smokeping/4d23aff8-pkg-4d23aff8-pr-92/index.html https://lsio-ci.ams3.digitaloceanspaces.com/lspipepr/smokeping/4d23aff8-pkg-4d23aff8-pr-92/shellcheck-result.xml

ironicbadger commented 4 years ago

This looks like a great addition! I made these changes locally and it seems to require existing data to be removed for DNS history.

That's not great for users who might have years worth of data? Any ideas on making it so that isn't required?

jandahl commented 4 years ago

Good point! Maybe it should be a different "tree" in the install.

github-actions[bot] commented 4 years ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

jandahl commented 4 years ago

I've amended to meet this concern and will send a new PR

LinuxServer-CI commented 4 years ago

I am a bot, here are the test results for this PR: https://lsio-ci.ams3.digitaloceanspaces.com/lspipepr/smokeping/57c0ea26-pkg-57c0ea26-pr-92/index.html https://lsio-ci.ams3.digitaloceanspaces.com/lspipepr/smokeping/57c0ea26-pkg-57c0ea26-pr-92/shellcheck-result.xml

LinuxServer-CI commented 4 years ago

I am a bot, here are the test results for this PR: https://lsio-ci.ams3.digitaloceanspaces.com/lspipepr/smokeping/57c0ea26-pkg-57c0ea26-pr-92/index.html https://lsio-ci.ams3.digitaloceanspaces.com/lspipepr/smokeping/57c0ea26-pkg-57c0ea26-pr-92/shellcheck-result.xml