search

linuxserver / docker-snipe-it

Alpine/Nginx container for the Asset Management software Snipe-IT
GNU General Public License v3.0
123 stars 26 forks source link

Standard base #28

Closed nemchik closed 1 year ago

nemchik commented 2 years ago

Ref: https://github.com/linuxserver/docker-baseimage-alpine-nginx/pull/84

Jenkins screenshots look odd.

Tested and working. Not sure why jenkins screenshots are broken, but the way this is replacing things in the nginx.conf seems unnecessary to me.

LinuxServer-CI commented 2 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/snipe-it/v5.2.0-pkg-1031efb0-pr-28/index.html https://ci-tests.linuxserver.io/lspipepr/snipe-it/v5.2.0-pkg-1031efb0-pr-28/shellcheck-result.xml

github-actions[bot] commented 2 years ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

LinuxServer-CI commented 2 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/snipe-it/v5.3.6-pkg-97f44618-pr-28/index.html https://ci-tests.linuxserver.io/lspipepr/snipe-it/v5.3.6-pkg-97f44618-pr-28/shellcheck-result.xml

LinuxServer-CI commented 2 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/snipe-it/v6.0.9-pkg-340c5de3-pr-28/index.html https://ci-tests.linuxserver.io/lspipepr/snipe-it/v6.0.9-pkg-340c5de3-pr-28/shellcheck-result.xml

LinuxServer-CI commented 2 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/snipe-it/v6.0.9-pkg-340c5de3-pr-28/index.html https://ci-tests.linuxserver.io/lspipepr/snipe-it/v6.0.9-pkg-340c5de3-pr-28/shellcheck-result.xml

LinuxServer-CI commented 2 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/snipe-it/v6.0.9-pkg-340c5de3-pr-28/index.html https://ci-tests.linuxserver.io/lspipepr/snipe-it/v6.0.9-pkg-340c5de3-pr-28/shellcheck-result.xml

LinuxServer-CI commented 2 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/snipe-it/v6.0.9-pkg-340bca6f-pr-28/index.html https://ci-tests.linuxserver.io/lspipepr/snipe-it/v6.0.9-pkg-340bca6f-pr-28/shellcheck-result.xml

LinuxServer-CI commented 2 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/snipe-it/v6.0.9-pkg-340bca6f-pr-28/index.html https://ci-tests.linuxserver.io/lspipepr/snipe-it/v6.0.9-pkg-340bca6f-pr-28/shellcheck-result.xml

LinuxServer-CI commented 2 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/snipe-it/v6.0.9-pkg-340bca6f-pr-28/index.html https://ci-tests.linuxserver.io/lspipepr/snipe-it/v6.0.9-pkg-340bca6f-pr-28/shellcheck-result.xml

LinuxServer-CI commented 2 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/snipe-it/v6.0.9-pkg-340bca6f-pr-28/index.html https://ci-tests.linuxserver.io/lspipepr/snipe-it/v6.0.9-pkg-340bca6f-pr-28/shellcheck-result.xml

LinuxServer-CI commented 2 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/snipe-it/v6.0.9-pkg-340bca6f-pr-28/index.html https://ci-tests.linuxserver.io/lspipepr/snipe-it/v6.0.9-pkg-340bca6f-pr-28/shellcheck-result.xml

LinuxServer-CI commented 1 year ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/snipe-it/v6.0.10-pkg-7ff3baad-pr-28/index.html https://ci-tests.linuxserver.io/lspipepr/snipe-it/v6.0.10-pkg-7ff3baad-pr-28/shellcheck-result.xml

LinuxServer-CI commented 1 year ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/snipe-it/v6.0.10-pkg-2eb37743-pr-28/index.html https://ci-tests.linuxserver.io/lspipepr/snipe-it/v6.0.10-pkg-2eb37743-pr-28/shellcheck-result.xml

LinuxServer-CI commented 1 year ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/snipe-it/v6.0.11-pkg-2eb37743-pr-28/index.html https://ci-tests.linuxserver.io/lspipepr/snipe-it/v6.0.11-pkg-2eb37743-pr-28/shellcheck-result.xml

LinuxServer-CI commented 1 year ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/snipe-it/v6.0.13-pkg-7a3a841a-pr-28/index.html https://ci-tests.linuxserver.io/lspipepr/snipe-it/v6.0.13-pkg-7a3a841a-pr-28/shellcheck-result.xml

nemchik commented 1 year ago

Clean install LGTM, though might be worth adding a check for the APP_URL being set because the container falls over if its not as nginx won't load the conf.

Addressed in https://github.com/linuxserver/docker-snipe-it/pull/28/commits/36fac0d8d3d379ede64a368965f58546ee9dc094

LinuxServer-CI commented 1 year ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/snipe-it/v6.0.13-pkg-7a3a841a-pr-28/index.html https://ci-tests.linuxserver.io/lspipepr/snipe-it/v6.0.13-pkg-7a3a841a-pr-28/shellcheck-result.xml