search

linuxserver / docker-snipe-it

Alpine/Nginx container for the Asset Management software Snipe-IT
GNU General Public License v3.0
123 stars 26 forks source link

Include APP_URL in required parameters #32

Closed ADobin closed 2 years ago

ADobin commented 2 years ago

linuxserver.io

Description:

Add APP_URL back as a required parameter and include documentation for what the values should be.

Benefits of this PR and context:

The environment variable APP_URL was removed in b6cd511183599a7b5a486e8cd77c2efa91e4c5b6 because the value that was trying to be set conflicted with the required value for Snipe-IT. This in inadvertently removed a required value for running Snipe-IT (see Snipe-IT documentation for required values). Failing to set or improperly setting this value can lead to various issues with rendering of images and QR codes.

closes #25

How Has This Been Tested?

Tested this with my local running copy that is proxied through traefik. Without setting this value, I was unable to see the QR codes because it was referencing a different URL than what I was running Snipe-IT on. After setting this value, the QR codes started rendering correctly.

Source / References:

LinuxServer-CI commented 2 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/snipe-it/v5.3.6-pkg-a2455632-pr-32/index.html https://ci-tests.linuxserver.io/lspipepr/snipe-it/v5.3.6-pkg-a2455632-pr-32/shellcheck-result.xml

github-actions[bot] commented 2 years ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.