search

linuxserver / docker-snipe-it

Alpine/Nginx container for the Asset Management software Snipe-IT
GNU General Public License v3.0
123 stars 26 forks source link

Configure support for X-Forwarded-User header auth #46

Closed MBPotier closed 1 year ago

MBPotier commented 1 year ago

linuxserver.io

Description:

I added support for HTTP header auth via the X-Forwarded-User header in the Nginx site config.

Benefits of this PR and context:

Snipe-IT supports authentication via the REMOTE_USER HTTP header; this feature can be enabled in its settings. This is useful for SSO and is unsupported in the container currently. The X-Forwarded-User header is often used to pass the username from a reverse proxy to the application.

How Has This Been Tested?

Built the container with the changes and tested it on my server.

nemchik commented 1 year ago

This will need to be rebased after https://github.com/linuxserver/docker-snipe-it/pull/28 merges.

28 should be ready to go, but any additional testing of lspipepr/snipe-it:v6.0.11-pkg-2eb37743-pr-28 is appreciated (leave comments on #28 with any issues, or confirmation that it works as expected).

LinuxServer-CI commented 1 year ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/snipe-it/v6.0.11-pkg-4a861c40-pr-46/index.html https://ci-tests.linuxserver.io/lspipepr/snipe-it/v6.0.11-pkg-4a861c40-pr-46/shellcheck-result.xml

github-actions[bot] commented 1 year ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.