search

linuxserver / docker-snipe-it

Alpine/Nginx container for the Asset Management software Snipe-IT
GNU General Public License v3.0
123 stars 26 forks source link

[BUG] APP_LOCALE default should be en-US instead of en #71

Open Tyree opened 2 months ago

Tyree commented 2 months ago

Is there an existing issue for this?

Current Behavior

With the APP_LOCALE being set to en, the laravel logs will repeatedly spit out: production.WARNING: APP_LOCALE in .env is set to en and should be updated to be en-US
As the warning indicates, I assume this only happens when in production mode. Propose the default be set to en-US and the readme be updated to reflect this. Thanks!

Expected Behavior

en being the default ENV setting for APP_LOCALE, no errors in logs (storage/logs/laravel.log)

Steps To Reproduce

  1. Leave APP_LOCALE set as default "en"
  2. Start container
  3. browse laravel logs under storage/logs/laravel.log

Environment

- OS: unRAID
- How docker service was installed: Community Apps

CPU architecture

x86-64

Docker creation

unRAID

Container logs

The container log does not show this error.
github-actions[bot] commented 2 months ago

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

Tyree commented 2 months ago

The official Snipe-It docs have now been updated to show en-US as the correct code for English (US).

LinuxServer-CI commented 1 month ago

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.