search

linuxserver / docker-speedtest-tracker

GNU General Public License v3.0
87 stars 2 forks source link

[FEAT] Upgrading to PHP 8.3 #11

Closed alexjustesen closed 7 months ago

alexjustesen commented 7 months ago

Is this a new feature request?

Wanted change

I've upgraded the development image to PHP 8.3 (https://github.com/alexjustesen/speedtest-tracker/pull/1385), looking to make the same change for the LSIO image.

Reason for change

Upgrading to the most current version of PHP.

Proposed code change

No response

github-actions[bot] commented 7 months ago

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

aptalca commented 7 months ago

Just to confirm, v0.18.7 is compatible with php 8.3, right? Because that's what we'll be building in the PR.

alexjustesen commented 7 months ago

Just to confirm, v0.18.7 is compatible with php 8.3, right? Because that's what we'll be building in the PR.

v0.19.0 incoming which includes compatibility tested code.

alexjustesen commented 7 months ago

https://github.com/alexjustesen/speedtest-tracker/releases/tag/v0.19.0 tagged and ready to roll on your schedule 👍

aptalca commented 7 months ago

PR opened. I locally built with v0.18.7 and spun up a fresh sqlite instance, didn't see any issues or errors. I'll try the v.019.0 tag just to make sure

aptalca commented 7 months ago

yup, local build of v0.19.0 also seems to be good with the rebase

alexjustesen commented 7 months ago

Awesome thank you! This reminds me I need to update my pipeline to use the LSIO base during testing so I can catch build errors before they hit your pipeline.

aptalca commented 7 months ago

Sounds good. Just waiting for a review from a team member and then we'll be good to merge and push