search

linuxserver / docker-speedtest-tracker

GNU General Public License v3.0
87 stars 2 forks source link

[BUG] "listen ... http2" directive is deprecated #17

Closed truthsword closed 5 months ago

truthsword commented 5 months ago

Is there an existing issue for this?

Current Behavior

Describe the bug Log report

nginx: [warn] the "listen ... http2" directive is deprecated, use the "http2" directive instead in /config/nginx/site-confs/default.conf:7

Environment (please complete the following information): Docker container:lastest

Expected Behavior

No warning

Steps To Reproduce

docker compose up

Environment

- OS:Debian Bookworm
- How docker service was installed: docker compose

CPU architecture

x86-64

Docker creation

services:
  speedtest-tracker:
    image: lscr.io/linuxserver/speedtest-tracker:latest
    container_name: speedtest-tracker
    restart: unless-stopped
    security_opt:
      - no-new-privileges=true
    environment:
      - PUID=1000
      - PGID=1000
      - APP_NAME=My Speedtest Tracker
      - PUBLIC_DASHBOARD=true
      - DB_CONNECTION=sqlite
    network_mode: bridge
    ports:
      - 8080:80 #HTTP
    #     - "8443:443" #HTTPS
    volumes:
      - config:/config
      - ssl-keys:/config/keys
    healthcheck:
      test: curl -fSs http://localhost/api/healthcheck || exit 1
      interval: 60s
      retries: 5
      start_period: 30s
      timeout: 10s

volumes:
  config: null
  ssl-keys: null

### Container logs

```bash
05/26/2024
    03:45:24 PM
    [migrations] started
    05/26/2024
    03:45:24 PM
    [migrations] 01-nginx-site-confs-default: skipped
    05/26/2024
    03:45:24 PM
    [migrations] done
    05/26/2024
    03:45:24 PM
    ───────────────────────────────────────
    05/26/2024
    03:45:24 PM
    05/26/2024
    03:45:24 PM
          ██╗     ███████╗██╗ ██████╗
    05/26/2024
    03:45:24 PM
          ██║     ██╔════╝██║██╔═══██╗
    05/26/2024
    03:45:24 PM
          ██║     ███████╗██║██║   ██║
    05/26/2024
    03:45:24 PM
          ██║     ╚════██║██║██║   ██║
    05/26/2024
    03:45:24 PM
          ███████╗███████║██║╚██████╔╝
    05/26/2024
    03:45:24 PM
          ╚══════╝╚══════╝╚═╝ ╚═════╝
    05/26/2024
    03:45:24 PM
    05/26/2024
    03:45:24 PM
       Brought to you by linuxserver.io
    05/26/2024
    03:45:24 PM
    ───────────────────────────────────────
    05/26/2024
    03:45:24 PM
    05/26/2024
    03:45:24 PM
    To support the app dev(s) visit:
    05/26/2024
    03:45:24 PM
    speedtest-tracker: https://github.com/sponsors/alexjustesen
    05/26/2024
    03:45:24 PM
    05/26/2024
    03:45:24 PM
    To support LSIO projects visit:
    05/26/2024
    03:45:24 PM
    https://www.linuxserver.io/donate/
    05/26/2024
    03:45:24 PM
    05/26/2024
    03:45:24 PM
    ───────────────────────────────────────
    05/26/2024
    03:45:24 PM
    GID/UID
    05/26/2024
    03:45:24 PM
    ───────────────────────────────────────
    05/26/2024
    03:45:24 PM
    05/26/2024
    03:45:24 PM
    User UID:    1000
    05/26/2024
    03:45:24 PM
    User GID:    1000
    05/26/2024
    03:45:24 PM
    ───────────────────────────────────────
    05/26/2024
    03:45:24 PM
    Linuxserver.io version: v0.19.0-ls23
    05/26/2024
    03:45:24 PM
    Build-date: 2024-05-24T19:25:11+00:00
    05/26/2024
    03:45:24 PM
    ───────────────────────────────────────
    05/26/2024
    03:45:24 PM

    05/26/2024
    03:45:24 PM
    using keys found in /config/keys
    05/26/2024
    03:45:24 PM
    An application key was generated at start up, as no environment variable was set.
    05/26/2024
    03:45:24 PM
    To set an application key that persists, read the docs: https://docs.speedtest-tracker.dev/
    05/26/2024
    03:45:25 PM
    [custom-init] No custom files found, skipping...
    05/26/2024
    03:45:25 PM
    [ls.io-init] done.
    05/26/2024
    03:45:25 PM
    nginx: [warn] the "listen ... http2" directive is deprecated, use the "http2" directive instead in /config/nginx/site-confs/default.conf:7
    05/26/2024
    03:45:25 PM
    nginx: [warn] the "listen ... http2" directive is deprecated, use the "http2" directive instead in /config/nginx/site-confs/default.conf:8
github-actions[bot] commented 5 months ago

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

thespad commented 5 months ago

https://github.com/linuxserver/docker-speedtest-tracker/releases/tag/v0.19.0-ls24

truthsword commented 5 months ago

Thanks!

mmomjian commented 5 months ago

edit: my bad, sorry

TheGroundZero commented 4 months ago

I still seem to be getting this error?

$ journalctl --user -xeu container-speedtest.service
Hint: You are currently not seeing messages from the system.
      Users in groups 'adm', 'systemd-journal', 'wheel' can see all messages.
      Pass -q to turn off this notice.
Jun 20 22:20:15 fedoracore speedtest-tracker[2235]:       ██╗     ███████╗██╗ ██████╗
Jun 20 22:20:15 fedoracore speedtest-tracker[2235]:       ██║     ██╔════╝██║██╔═══██╗
Jun 20 22:20:15 fedoracore speedtest-tracker[2235]:       ██║     ███████╗██║██║   ██║
Jun 20 22:20:15 fedoracore speedtest-tracker[2235]:       ██║     ╚════██║██║██║   ██║
Jun 20 22:20:15 fedoracore speedtest-tracker[2235]:       ███████╗███████║██║╚██████╔╝
Jun 20 22:20:15 fedoracore speedtest-tracker[2235]:       ╚══════╝╚══════╝╚═╝ ╚═════╝
Jun 20 22:20:15 fedoracore speedtest-tracker[2235]:
Jun 20 22:20:15 fedoracore speedtest-tracker[2235]:    Brought to you by linuxserver.io
Jun 20 22:20:15 fedoracore speedtest-tracker[2235]: ───────────────────────────────────────
Jun 20 22:20:15 fedoracore speedtest-tracker[2235]:
Jun 20 22:20:15 fedoracore speedtest-tracker[2235]: To support the app dev(s) visit:
Jun 20 22:20:15 fedoracore speedtest-tracker[2235]: speedtest-tracker: https://github.com/sponsors/alexjustesen
Jun 20 22:20:15 fedoracore speedtest-tracker[2235]:
Jun 20 22:20:15 fedoracore speedtest-tracker[2235]: To support LSIO projects visit:
Jun 20 22:20:15 fedoracore speedtest-tracker[2235]: https://www.linuxserver.io/donate/
Jun 20 22:20:15 fedoracore speedtest-tracker[2235]:
Jun 20 22:20:15 fedoracore speedtest-tracker[2235]: ───────────────────────────────────────
Jun 20 22:20:15 fedoracore speedtest-tracker[2235]: GID/UID
Jun 20 22:20:15 fedoracore speedtest-tracker[2235]: ───────────────────────────────────────
Jun 20 22:20:15 fedoracore speedtest-tracker[2235]:
Jun 20 22:20:15 fedoracore speedtest-tracker[2235]: User UID:    1001
Jun 20 22:20:15 fedoracore speedtest-tracker[2235]: User GID:    1001
Jun 20 22:20:15 fedoracore speedtest-tracker[2235]: ───────────────────────────────────────
Jun 20 22:20:15 fedoracore speedtest-tracker[2235]: Linuxserver.io version: v0.20.6-ls30
Jun 20 22:20:15 fedoracore speedtest-tracker[2235]: Build-date: 2024-06-15T21:23:04+00:00
Jun 20 22:20:15 fedoracore speedtest-tracker[2235]: ───────────────────────────────────────
Jun 20 22:20:15 fedoracore speedtest-tracker[2235]:
Jun 20 22:20:16 fedoracore speedtest-tracker[2235]: using keys found in /config/keys
Jun 20 22:20:21 fedoracore speedtest-tracker[2235]: **** The following active confs have different version dates than the samples that are shipped. ****
Jun 20 22:20:21 fedoracore speedtest-tracker[2235]: **** This may be due to user customization or an update to the samples. ****
Jun 20 22:20:21 fedoracore speedtest-tracker[2235]: **** You should compare the following files to the samples in the same folder and update them. ****
Jun 20 22:20:21 fedoracore speedtest-tracker[2235]: **** Use the link at the top of the file to view the changelog. ****
Jun 20 22:20:21 fedoracore speedtest-tracker[2235]: ┌────────────┬────────────┬────────────────────────────────────────────────────────────────────────┐
Jun 20 22:20:21 fedoracore speedtest-tracker[2235]: │  old date  │  new date  │ path                                                                   │
Jun 20 22:20:21 fedoracore speedtest-tracker[2235]: ├────────────┼────────────┼────────────────────────────────────────────────────────────────────────┤
Jun 20 22:20:21 fedoracore speedtest-tracker[2235]: │ 2023-04-13 │ 2024-05-27 │ /config/nginx/nginx.conf                                               │
Jun 20 22:20:21 fedoracore speedtest-tracker[2235]: │ 2023-04-13 │ 2024-05-28 │ /config/nginx/site-confs/default.conf                                  │
Jun 20 22:20:21 fedoracore speedtest-tracker[2235]: └────────────┴────────────┴────────────────────────────────────────────────────────────────────────┘
Jun 20 22:20:21 fedoracore speedtest-tracker[2235]: [custom-init] No custom files found, skipping...
Jun 20 22:20:21 fedoracore speedtest-tracker[2235]: nginx: [warn] the "listen ... http2" directive is deprecated, use the "http2" directive instead in /con>
Jun 20 22:20:21 fedoracore speedtest-tracker[2235]: nginx: [warn] the "listen ... http2" directive is deprecated, use the "http2" directive instead in /con>
Jun 20 22:20:21 fedoracore speedtest-tracker[2235]: [ls.io-init] done.
$ podman exec speedtest-tracker head /config/nginx/site-confs/default.conf
## Version 2023/04/13 - Changelog: https://github.com/linuxserver/docker-speedtest-tracker/commits/master/root/defaults/nginx/site-confs/default.conf.sample

server {
    listen 80 default_server;
    listen [::]:80 default_server;

    listen 443 ssl http2 default_server;
    listen [::]:443 ssl http2 default_server;

    server_name _;
$ podman inspect -f '{{ index .Config.Labels "build_version" }}' lscr.io/linuxserver/speedtest-tracker:latest
Linuxserver.io version:- v0.20.6-ls30 Build-date:- 2024-06-15T21:23:04+00:00
$ podman inspect -f '{{ index .Config.Labels "build_version" }}' speedtest-tracker
Linuxserver.io version:- v0.20.6-ls30 Build-date:- 2024-06-15T21:23:04+00:00
$ cat [host folder for container]/config/nginx/site-confs/default.conf
## Version 2023/04/13 - Changelog: https://github.com/linuxserver/docker-speedtest-tracker/commits/master/root/defaults/nginx/site-confs/default.conf.sample

server {
    listen 80 default_server;
    listen [::]:80 default_server;

    listen 443 ssl http2 default_server;
    listen [::]:443 ssl http2 default_server;

    server_name _;

    include /config/nginx/ssl.conf;

    root /app/www/public;
    index index.html index.htm index.php;

    location / {
        # enable for basic auth
        #auth_basic "Restricted";
        #auth_basic_user_file /config/nginx/.htpasswd;

        try_files $uri $uri/ /index.php$is_args$args;
    }

    location ~ ^(.+\.php)(.*)$ {
        fastcgi_split_path_info ^(.+\.php)(.*)$;
        fastcgi_pass 127.0.0.1:9000;
        fastcgi_index index.php;
        include /etc/nginx/fastcgi_params;
    }

    # deny access to .htaccess/.htpasswd files
    location ~ /\.ht {
        deny all;
    }
}

See also: https://github.com/alexjustesen/speedtest-tracker/issues/1553

Roxedus commented 4 months ago

From our releasenotes

Existing users should update their nginx confs to avoid http2 deprecation warnings.

If you know you haven't made changes to the file yourself, delete it, and restart the container.

TheGroundZero commented 4 months ago

From our releasenotes

Existing users should update their nginx confs to avoid http2 deprecation warnings.

If you know you haven't made changes to the file yourself, delete it, and restart the container.

That kinda(?) fixed it. Thanks!

$ podman exec speedtest-tracker rm -f /config/nginx/site-confs/default.conf
$ podman exec speedtest-tracker cat /config/nginx/site-confs/default.conf
cat: /config/nginx/site-confs/default.conf: No such file or directory

$ systemctl --user restart container-speedtest.service

$ journalctl --user -xeu container-speedtest.service
Hint: You are currently not seeing messages from the system.
      Users in groups 'adm', 'systemd-journal', 'wheel' can see all messages.
      Pass -q to turn off this notice.
Jun 21 07:28:10 fedoracore speedtest-tracker[30164]: [migrations] done
Jun 21 07:28:10 fedoracore speedtest-tracker[30164]: ───────────────────────────────────────
Jun 21 07:28:10 fedoracore speedtest-tracker[30164]:
Jun 21 07:28:10 fedoracore speedtest-tracker[30164]:       ██╗     ███████╗██╗ ██████╗
Jun 21 07:28:10 fedoracore speedtest-tracker[30164]:       ██║     ██╔════╝██║██╔═══██╗
Jun 21 07:28:10 fedoracore speedtest-tracker[30164]:       ██║     ███████╗██║██║   ██║
Jun 21 07:28:10 fedoracore speedtest-tracker[30164]:       ██║     ╚════██║██║██║   ██║
Jun 21 07:28:10 fedoracore speedtest-tracker[30164]:       ███████╗███████║██║╚██████╔╝
Jun 21 07:28:10 fedoracore speedtest-tracker[30164]:       ╚══════╝╚══════╝╚═╝ ╚═════╝
Jun 21 07:28:10 fedoracore speedtest-tracker[30164]:
Jun 21 07:28:10 fedoracore speedtest-tracker[30164]:    Brought to you by linuxserver.io
Jun 21 07:28:10 fedoracore speedtest-tracker[30164]: ───────────────────────────────────────
Jun 21 07:28:10 fedoracore speedtest-tracker[30164]:
Jun 21 07:28:10 fedoracore speedtest-tracker[30164]: To support the app dev(s) visit:
Jun 21 07:28:10 fedoracore speedtest-tracker[30164]: speedtest-tracker: https://github.com/sponsors/alexjustesen
Jun 21 07:28:10 fedoracore speedtest-tracker[30164]:
Jun 21 07:28:10 fedoracore speedtest-tracker[30164]: To support LSIO projects visit:
Jun 21 07:28:10 fedoracore speedtest-tracker[30164]: https://www.linuxserver.io/donate/
Jun 21 07:28:10 fedoracore speedtest-tracker[30164]:
Jun 21 07:28:10 fedoracore speedtest-tracker[30164]: ───────────────────────────────────────
Jun 21 07:28:10 fedoracore speedtest-tracker[30164]: GID/UID
Jun 21 07:28:10 fedoracore speedtest-tracker[30164]: ───────────────────────────────────────
Jun 21 07:28:10 fedoracore speedtest-tracker[30164]:
Jun 21 07:28:10 fedoracore speedtest-tracker[30164]: User UID:    1001
Jun 21 07:28:10 fedoracore speedtest-tracker[30164]: User GID:    1001
Jun 21 07:28:10 fedoracore speedtest-tracker[30164]: ───────────────────────────────────────
Jun 21 07:28:10 fedoracore speedtest-tracker[30164]: Linuxserver.io version: v0.20.6-ls30
Jun 21 07:28:10 fedoracore speedtest-tracker[30164]: Build-date: 2024-06-15T21:23:04+00:00
Jun 21 07:28:10 fedoracore speedtest-tracker[30164]: ───────────────────────────────────────
Jun 21 07:28:10 fedoracore speedtest-tracker[30164]:
Jun 21 07:28:10 fedoracore speedtest-tracker[30164]: using keys found in /config/keys
Jun 21 07:28:12 fedoracore speedtest-tracker[30164]: **** The following active confs have different version dates than the samples that are shipped. ****
Jun 21 07:28:12 fedoracore speedtest-tracker[30164]: **** This may be due to user customization or an update to the samples. ****
Jun 21 07:28:12 fedoracore speedtest-tracker[30164]: **** You should compare the following files to the samples in the same folder and update them. ****
Jun 21 07:28:12 fedoracore speedtest-tracker[30164]: **** Use the link at the top of the file to view the changelog. ****
Jun 21 07:28:12 fedoracore speedtest-tracker[30164]: ┌────────────┬────────────┬────────────────────────────────────────────────────────────────────────┐
Jun 21 07:28:12 fedoracore speedtest-tracker[30164]: │  old date  │  new date  │ path                                                                   │
Jun 21 07:28:12 fedoracore speedtest-tracker[30164]: ├────────────┼────────────┼────────────────────────────────────────────────────────────────────────┤
Jun 21 07:28:12 fedoracore speedtest-tracker[30164]: │ 2023-04-13 │ 2024-05-27 │ /config/nginx/nginx.conf                                               │
Jun 21 07:28:12 fedoracore speedtest-tracker[30164]: └────────────┴────────────┴────────────────────────────────────────────────────────────────────────┘
Jun 21 07:28:12 fedoracore speedtest-tracker[30164]: [custom-init] No custom files found, skipping...
Jun 21 07:28:12 fedoracore speedtest-tracker[30164]: [ls.io-init] done.
$ podman exec speedtest-tracker cat /config/nginx/site-confs/default.conf
## Version 2024/05/28 - Changelog: https://github.com/linuxserver/docker-speedtest-tracker/commits/master/root/defaults/nginx/site-confs/default.conf.sample

server {
    listen *:80 default_server;
    listen *:443 ssl default_server;

    server_name _;

    include /config/nginx/ssl.conf;
[...]