search

linuxserver / docker-swag

Nginx webserver and reverse proxy with php support and a built-in Certbot (Let's Encrypt) client. It also contains fail2ban for intrusion prevention.
https://docs.linuxserver.io/general/swag
GNU General Public License v3.0
2.84k stars 243 forks source link

Can not use he as DNSPLUGIN. #167

Closed CrazyMyOrange closed 2 years ago

CrazyMyOrange commented 2 years ago

When I use "-e DNSPLUGIN=he" for DNS VALIDATION, it told me

stdout: Please set the DNSPLUGIN variable to a valid plugin name. See docker info for more details.

Then I check the file

docker-swag/root/etc/cont-init.d/50-config, line 125,

check to make sure DNSPLUGIN is selected if dns validation is used [[ "$VALIDATION" = "dns" ]] && [[ ! "$DNSPLUGIN" =~ ^(aliyun|cloudflare|cloudxns|cpanel|digitalocean|directadmin|dnsimple|dnsmadeeasy|domeneshop|gandi|gehirn|google|hetzner|inwx|ionos|linode|luadns|netcup|njalla|nsone|ovh|rfc2136|route53|sakuracloud|transip|vultr)$ ]] && \ echo "Please set the DNSPLUGIN variable to a valid plugin name. See docker info for more details." && \ sleep infinity

There isn't an option named he, Then I noticed the same file, line 239.

elif [[ "$DNSPLUGIN" =~ ^(aliyun|domeneshop|he|hetzner|inwx|ionos|netcup|njalla|transip|vultr)$ ]]; then

There is an option named he.

Is this a bug? I am not a programmer, so I could be wrong.

github-actions[bot] commented 2 years ago

Thanks for opening your first issue here! Be sure to follow the bug or feature issue templates!

aptalca commented 2 years ago

It's a bug. The user who PRed it didn't test it properly: https://github.com/linuxserver/docker-swag/pull/164/files We'll get it fixed. Thanks for the heads up