linuxserver / docker-swag

Nginx webserver and reverse proxy with php support and a built-in Certbot (Let's Encrypt) client. It also contains fail2ban for intrusion prevention.
https://docs.linuxserver.io/general/swag
GNU General Public License v3.0
2.66k stars 231 forks source link

[BUG] Cloudflare API Update #482

Closed fentix closed 1 week ago

fentix commented 1 month ago

Is there an existing issue for this?

Current Behavior

Installed a new SWAG Container and got a warning because cloudflare will retire the current API The Linuxserver-CI Bot updated the cloudflare 2.20.0 python package with the commit 95c13d0 which causes a warning.

Expected Behavior

No Warning Message. (Updating the API to 3.0 or Downgrading the API to 2.19 for now.)

Steps To Reproduce

  1. Create a SWAG container with the current lscr.io/linuxserver/swag:latest
  2. Use The cloudflare DNS Validation for SSL-Cert generation
  3. Look at the output Logs after starting the container.

Environment

- OS:
- How docker service was installed:

CPU architecture

arm64

Docker creation

version: "2.4"

services:

  swag:
    image: lscr.io/linuxserver/swag:latest
    container_name: swag
    cap_add:
      - NET_ADMIN
    environment:
      - PUID=1000
      - PGID=1000
      - TZ=Etc/UTC
      - URL=domain.tld
      - SUBDOMAINS=salt,pepper #add some subdomains
      - VALIDATION=dns
      - DNSPLUGIN=cloudflare
      - EMAIL=mail@example.com
      - PROPAGATION=20
    volumes:
      - path/swag:/config
    networks:
      - examplenet
    ports:
      - "443:443"
      - "80:80"   
    restart: unless-stopped
    labels:
      - com.centurylinklabs.watchtower.enable=true  # Watchtower

networks:
  examplenet:
    external: true

Container logs

!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!   WARNING  !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
       !! You're seeing this warning because you've upgraded the Python package 'cloudflare' to version
       !! 2.20.* via an automated upgrade without version pinning. Version 2.20.0 exists to catch any    !!
       !! of these upgrades before Cloudflare releases a new major release under the release number 3.x. !!
       !!                                                                                                !!
       !! Should you determine that you need to revert this upgrade and pin to v2.19.* it is recommended !!
       !! you do the following: pip install --upgrade cloudflare==2.19.* or equivilant.                  !!
       !!                                                                                                !!
       !! Or you can upgrade to v3.x. NOTE: Release 3.x will not be code-compatible or call-compatible   !!
       !! with previous releases. To see more about upgrading to next major version, please see:         !!
       !! https://github.com/cloudflare/python-cloudflare/discussions/191                                !!
       !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
aptalca commented 1 month ago

Upstream issue, they're aware: https://github.com/certbot/certbot/pull/9940

quietsy commented 1 week ago

The previous version of certbot has been pinned and the issue no longer reproduces.