search

linuxserver / docker-syncthing

GNU General Public License v3.0
300 stars 45 forks source link

Add configurable WebUI PORT #70

Closed wansyu closed 6 months ago

wansyu commented 10 months ago

linuxserver.io

Description:

Add optional configurable WebUI PORT.

Benefits of this PR and context:

The current image cannot change the internal port of WebUI. This commit adds the PORT environment variable to avoid port conflicts that may be caused by hardcoded port when using the host network.

How Has This Been Tested?

I built an image from a Dockerfile and used it to create and run 2 containers simultaneously on the same host. Both Syncthing instances are successfully accessible through the GUI on the assigned ports, local discovery functions properly, and the instances are able to connect directly to other Syncthing instances on the local network.

Source / References:

[FEAT] Add option to set listen address for GUI https://github.com/linuxserver/docker-syncthing/issues/65

LinuxServer-CI commented 10 months ago
I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/syncthing/v1.27.1-pkg-a42c0aec-dev-a0949c1c55e7de99f5a7ecf4db8626e255ecda5d-pr-70/index.html https://ci-tests.linuxserver.io/lspipepr/syncthing/v1.27.1-pkg-a42c0aec-dev-a0949c1c55e7de99f5a7ecf4db8626e255ecda5d-pr-70/shellcheck-result.xml Tag Passed
amd64-v1.27.1-pkg-a42c0aec-dev-a0949c1c55e7de99f5a7ecf4db8626e255ecda5d-pr-70 ✅
arm64v8-v1.27.1-pkg-a42c0aec-dev-a0949c1c55e7de99f5a7ecf4db8626e255ecda5d-pr-70 ✅
LinuxServer-CI commented 9 months ago

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

RayBB commented 9 months ago

@wansyu I posted on linuxserver discord asking about this and got the following response:

I don't particularly see an issue with making the port configurable for use in host networking mode, though I'm not really clear why it would be necessary, but we wouldn't make those changes to the Dockerfile, and we'd want to pick a clearer env name than just PORT

LinuxServer-CI commented 8 months ago

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 5 months ago

This pull request is locked due to inactivity