search

linuxserver / docker-syncthing

GNU General Public License v3.0
300 stars 45 forks source link

Mark data volumes as optional #79

Open tobiasdiez opened 4 months ago

tobiasdiez commented 4 months ago

linuxserver.io

Description:

My understanding is that the two data volumes are optional. Thus, I've moved them to opt_param_volumes.

(I guessed that this is the proper handling of optional volumes based on some other examples.)

Benefits of this PR and context:

How Has This Been Tested?

Untested.

Source / References:

LinuxServer-CI commented 4 months ago
I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/syncthing/v1.27.8-pkg-50571711-dev-f4a96502bbfc7f6f0e0828fca7771f36953d6bb9-pr-79/index.html https://ci-tests.linuxserver.io/lspipepr/syncthing/v1.27.8-pkg-50571711-dev-f4a96502bbfc7f6f0e0828fca7771f36953d6bb9-pr-79/shellcheck-result.xml Tag Passed
amd64-v1.27.8-pkg-50571711-dev-f4a96502bbfc7f6f0e0828fca7771f36953d6bb9-pr-79 ✅
arm64v8-v1.27.8-pkg-50571711-dev-f4a96502bbfc7f6f0e0828fca7771f36953d6bb9-pr-79 ✅
LinuxServer-CI commented 3 months ago
I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/syncthing/v1.27.9-pkg-f1885775-dev-9660a69de443388321f3b158635f6fba71fe6a65-pr-79/index.html https://ci-tests.linuxserver.io/lspipepr/syncthing/v1.27.9-pkg-f1885775-dev-9660a69de443388321f3b158635f6fba71fe6a65-pr-79/shellcheck-result.xml Tag Passed
amd64-v1.27.9-pkg-f1885775-dev-9660a69de443388321f3b158635f6fba71fe6a65-pr-79 ✅
arm64v8-v1.27.9-pkg-f1885775-dev-9660a69de443388321f3b158635f6fba71fe6a65-pr-79 ✅
LinuxServer-CI commented 3 months ago
I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/syncthing/v1.27.9-pkg-de7afe96-dev-353cab92e0e6290eed30ce0e61f6b691e1afefe3-pr-79/index.html https://ci-tests.linuxserver.io/lspipepr/syncthing/v1.27.9-pkg-de7afe96-dev-353cab92e0e6290eed30ce0e61f6b691e1afefe3-pr-79/shellcheck-result.xml Tag Passed
amd64-v1.27.9-pkg-de7afe96-dev-353cab92e0e6290eed30ce0e61f6b691e1afefe3-pr-79 ✅
arm64v8-v1.27.9-pkg-de7afe96-dev-353cab92e0e6290eed30ce0e61f6b691e1afefe3-pr-79 ✅
LinuxServer-CI commented 2 months ago
I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/syncthing/v1.27.10-pkg-361b33fa-dev-7515173da9a726d7176ddbd9041971650b9641ad-pr-79/index.html https://ci-tests.linuxserver.io/lspipepr/syncthing/v1.27.10-pkg-361b33fa-dev-7515173da9a726d7176ddbd9041971650b9641ad-pr-79/shellcheck-result.xml Tag Passed
amd64-v1.27.10-pkg-361b33fa-dev-7515173da9a726d7176ddbd9041971650b9641ad-pr-79 ✅
arm64v8-v1.27.10-pkg-361b33fa-dev-7515173da9a726d7176ddbd9041971650b9641ad-pr-79 ✅
LinuxServer-CI commented 1 month ago
I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/syncthing/v1.27.12-pkg-1244413a-dev-2c7a45192c9978d5166e16e3fbf3c088c200ca77-pr-79/index.html https://ci-tests.linuxserver.io/lspipepr/syncthing/v1.27.12-pkg-1244413a-dev-2c7a45192c9978d5166e16e3fbf3c088c200ca77-pr-79/shellcheck-result.xml Tag Passed
amd64-v1.27.12-pkg-1244413a-dev-2c7a45192c9978d5166e16e3fbf3c088c200ca77-pr-79 ✅
arm64v8-v1.27.12-pkg-1244413a-dev-2c7a45192c9978d5166e16e3fbf3c088c200ca77-pr-79 ✅
LinuxServer-CI commented 1 week ago
I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/syncthing/v1.28.0-pkg-3f092f9e-dev-c5eee8ea15ed1977ba0ef227e9e7dc0734c57195-pr-79/index.html https://ci-tests.linuxserver.io/lspipepr/syncthing/v1.28.0-pkg-3f092f9e-dev-c5eee8ea15ed1977ba0ef227e9e7dc0734c57195-pr-79/shellcheck-result.xml Tag Passed
amd64-v1.28.0-pkg-3f092f9e-dev-c5eee8ea15ed1977ba0ef227e9e7dc0734c57195-pr-79 ✅
arm64v8-v1.28.0-pkg-3f092f9e-dev-c5eee8ea15ed1977ba0ef227e9e7dc0734c57195-pr-79 ✅