search

linuxserver / docker-tautulli

http://linuxserver.io
GNU General Public License v3.0
215 stars 39 forks source link

Add ADVANCED_GIT_BRANCH back into dockerfile #38

Closed wcomartin closed 7 years ago

wcomartin commented 7 years ago

ADVANCED_GIT_BRANCH was removed when changing the git clone process, I am aware this feature is not supported but as one of the devs working on and with plexpy i use this feature extensively, so i've added the branch code to the new location of git clone

Thanks

LinuxServer-CI commented 7 years ago

Can an admin please whisper to jenkins to test this PR.

sparklyballs commented 7 years ago

there's no way of utilising this variable without passing it as a build arg in the form (replacing dev with whichever branch you're interested in)

docker build -t linuxserver/plexpy --build-arg ADVANCED_GIT_BRANCH=dev .

and it requires a placeholder ARG ADVANCED_GIT_BRANCH at the top of the Dockerfile (anywhere after the FROM line would suffice for it to be usable.

also it would be a self build locally.

in summary, rather than merge this to our repo as unusable code, it would be better suited to a personal fork for your dev work.