search

linuxserver / docker-tautulli

http://linuxserver.io
GNU General Public License v3.0
214 stars 39 forks source link

Add PIP package for script support. #86

Closed justinglock40 closed 4 years ago

justinglock40 commented 4 years ago

Supports this script: https://github.com/clusterbox/scripts/blob/master/throttle_nzbclient.py

linuxserver.io

We welcome all PR’s though this doesn’t guarantee it will be accepted.

Description:

Added a PIP package that is needed for the script linked above.

Benefits of this PR and context:

Simple supports the script. Does not have a wide effect on the general user base unless they are plagued with it being missing when the container restarts and updates as well. I attempted to use the DOCKER_MODS ENV VAR, but was unsuccessful.

How Has This Been Tested?

Manually installed the pip package via BASH. No adverse affects to the functionality of the container in my usage.

Source / References:

LinuxServer-CI commented 4 years ago

I am a bot, here are the test results for this PR: https://lsio-ci.ams3.digitaloceanspaces.com/lspipepr/tautulli/v2.1.41-pkg-d7010085-pr-86/index.html https://lsio-ci.ams3.digitaloceanspaces.com/lspipepr/tautulli/v2.1.41-pkg-d7010085-pr-86/shellcheck-result.xml

thelamer commented 4 years ago

I think this would be better suited for customization https://blog.linuxserver.io/2019/09/14/customizing-our-containers/

Feel free to make a public facing mod hosted on Dockerhub, something that can be consumed by that stacks logic as a env variable. If it is very popular we can consider adding it by default.