search

linuxserver / docker-thelounge

GNU General Public License v3.0
25 stars 7 forks source link

Use s6 logutil-service for saving stdout/stderr to file #15

Closed ghost closed 5 years ago

ghost commented 6 years ago

logutil-service handles logging to a file as well as logrotation.

All output directly from thelounge is written to a file. Docker run output is not touched.

log_file docker_run

Logging to a file would allow fail2ban to check for failed login attempts once this code tagged in a release: https://github.com/thelounge/thelounge/pull/2247

LinuxServer-CI commented 6 years ago

Can an admin please whisper to jenkins to test this PR.

ghost commented 6 years ago

In the screenshot, I ran docker with -e S6_LOGGING_SCRIPT="n20 s1000000" which removes a timestamp because the output from thelounge already had a timestamp.

ghost commented 6 years ago

Should I close this?

thelamer commented 5 years ago

@McGriddle I know this is old, but just wanted to give you an answer. The general ideology on logs has been in the past that you should handle it with docker log drivers and rules. It is an interesting concept and particularly useful for stuff like development containers where your userspace is inside of the container and you have no visibility to the host level socket. With a daemonized application though I cannot see us implementing this, especially because fail-2-ban should be running host level or in a container with host access and in turn docker logs access and is not included in this container.