Closed hacketiwack closed 2 years ago
I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/transmission/3.00-r5-pkg-28b299a6-pr-197/index.html https://ci-tests.linuxserver.io/lspipepr/transmission/3.00-r5-pkg-28b299a6-pr-197/shellcheck-result.xml
I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/transmission/3.00-r5-pkg-adaaf183-pr-197/index.html https://ci-tests.linuxserver.io/lspipepr/transmission/3.00-r5-pkg-adaaf183-pr-197/shellcheck-result.xml
Solves this issue.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Is there still someone maintaining this repository?
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Is this repository still active?
Humm, inactive?
Humm, inactive?
It seems so... There's no news whatsoever...
I'll be honest. I'm not touching this PR because:
Thanks for the reply.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
closing this as we do not see a benefit to our userbase by accepting it. Users are free to use whatever folders they wish for downloads/incomplete. the existence of an empty directory does not preclude this.
Description:
The objective of this change is to avoid the creation of the different default directories: for downloads, incomplete downloads, and the watch folder. Indeed, even if the user has defined their directories, the default ones are annoyingly always created.
Benefits of this PR and context:
This change checks if there is already an existing
/config/settings.json
file and if yes, uses the configured directories. If there are no directories configured, then values for the directories defined in/defaults/settings.json
are taken.Moreover, the file has been simplified to be more readable and using the
jq
command (which is installed anyway) instead of less safesed
replacements.How Has This Been Tested?
Built with my own CI/CD pipeline on Azure DevOps and deployed on my test rig.
Source / References: