linuxserver / docker-transmission

GNU General Public License v3.0
582 stars 180 forks source link

[BUG] Image should not be built with assertions enabled #232

Closed rpatterson closed 1 year ago

rpatterson commented 1 year ago

Is there an existing issue for this?

Current Behavior

Running the image with torrents or other conditions that would trigger assertion errors do so as can be seen in the containers output.

Expected Behavior

End user builds should not enable assertions and as such this container image should not run with assertions enabled.

Steps To Reproduce

Run this container image with a set of torrents that trigger one or more assertion errors and note the errors. See this upstream issue for an example that multiple users have observed.

Environment

- OS: Ubuntu 22.04.1 LTS
- How docker service was installed: a `./docker-compose.yml` config including a bind mount volume containing existing torrents

CPU architecture

x86-64

Docker creation

From ./docker-compose.yml:

version: "3.8"
services:
  transmission:
    image: "linuxserver/transmission"
    container_name: "transmission"
    environment:
      TZ: "${TZ:-America/Los_Angeles}"
      PUID: "${PUID:-1000}"
      PGID: "${PGID:-100}"
      USER: "${TRANSMISSION_USER:-transmission}"
      PASS: "${TRANSMISSION_PASS}"
    volumes:
      - "./transmission/config/:/config/"
      - type: bind
        source: "${DOWNLOAD_VOLUME:-/media/Library/}"
        target: "${DOWNLOAD_VOLUME:-/media/Library/}"
        bind:
          propagation: "shared"

Container logs

...
transmission  | [custom-init] No custom files found, skipping...                                                                                                           
transmission  | assertion failed: bit_count_ == 0 || n <= bit_count_ (/home/buildozer/aports/community/transmission/src/transmission-4.0.0/libtransmission/bitfield.cc:233)
transmission  | ./run: line 6:   161 Aborted                 s6-notifyoncheck -d -n 300 -w 1000 -c "nc -z localhost 9091" s6-setuidgid abc /usr/bin/transmission-daemon -g 
/config -c /watch -f                                                                                                                                                       
...
thespad commented 1 year ago

We don't build transmission, we install it from the Alpine repos. It would need to be raised as an issue with their maintainers https://gitlab.alpinelinux.org/alpine/aports/-/issues

rpatterson commented 1 year ago

It would need to be raised as an issue with their maintainers

Raised in an existing issue.

rpatterson commented 1 year ago

They said to try -r6.

thespad commented 1 year ago

https://git.alpinelinux.org/aports/commit/community/transmission?id=0b5b15c6a7d7bd92d1e8e77b737572c16a0817f8

Once it's built, we'll pick it up and build a new image with r6.

rpatterson commented 1 year ago

Running -r6 I no longer see the assertion errors.