read download/incomplete directory paths from `settings.json`

cartfisk commented 5 months ago

[x] I have read the contributing guideline and understand that I have made the correct modifications

Description:

This PR replaces hardcoded paths for directory creation/ownership with paths parsed from settings.json. If paths cannot be found in the file, defaults are used.

For standard installations, this change has no effect. In the case that a user sets a custom path for download-dir and/or incomplete-dir in settings.json, the run script will mkdir/lsiown the custom directories instead of the defaults.

Benefits of this PR and context:

Currently, even if a user changes the path(s) of download-dir/incomplete-dir in settings.json, the run script will still mkdir/lsiown the default directories (/downloads/complete & /downloads/incomplete) every time the container starts. Although these unused directories don't pose any serious issue, they can be a nuisance when navigating with autocomplete in the command line.

How Has This Been Tested?

Ran jenkins-builder.

Source / References:

https://github.com/linuxserver/docker-transmission/issues/265 https://github.com/linuxserver/docker-transmission/issues/256 https://github.com/linuxserver/docker-transmission/pull/266

LinuxServer-CI commented 5 months ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/transmission/4.0.5-r0-pkg-b53f7895-dev-7c9cc02fb6e48c7fe745c694f77e3ef9b2095d39-pr-277/index.html https://ci-tests.linuxserver.io/lspipepr/transmission/4.0.5-r0-pkg-b53f7895-dev-7c9cc02fb6e48c7fe745c694f77e3ef9b2095d39-pr-277/shellcheck-result.xml	Tag	Passed
amd64-4.0.5-r0-pkg-b53f7895-dev-7c9cc02fb6e48c7fe745c694f77e3ef9b2095d39-pr-277	✅
arm64v8-4.0.5-r0-pkg-b53f7895-dev-7c9cc02fb6e48c7fe745c694f77e3ef9b2095d39-pr-277	✅

LinuxServer-CI commented 5 months ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/transmission/4.0.5-r0-pkg-b53f7895-dev-a96e3bcbf04905c1e474bedf6e8fcf1827ac2db5-pr-277/index.html https://ci-tests.linuxserver.io/lspipepr/transmission/4.0.5-r0-pkg-b53f7895-dev-a96e3bcbf04905c1e474bedf6e8fcf1827ac2db5-pr-277/shellcheck-result.xml	Tag	Passed
amd64-4.0.5-r0-pkg-b53f7895-dev-a96e3bcbf04905c1e474bedf6e8fcf1827ac2db5-pr-277	✅
arm64v8-4.0.5-r0-pkg-b53f7895-dev-a96e3bcbf04905c1e474bedf6e8fcf1827ac2db5-pr-277	✅

aptalca commented 5 months ago

lgtm Please add a changelog entry into readme-vars.yml and make sure it's tested well :-)

LinuxServer-CI commented 4 months ago

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

LinuxServer-CI commented 4 months ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/transmission/4.0.5-r1-pkg-43837386-dev-b753e9d0fdb7eef0669e783c4fd14e547a276798-pr-277/index.html https://ci-tests.linuxserver.io/lspipepr/transmission/4.0.5-r1-pkg-43837386-dev-b753e9d0fdb7eef0669e783c4fd14e547a276798-pr-277/shellcheck-result.xml	Tag	Passed
amd64-4.0.5-r1-pkg-43837386-dev-b753e9d0fdb7eef0669e783c4fd14e547a276798-pr-277	✅
arm64v8-4.0.5-r1-pkg-43837386-dev-b753e9d0fdb7eef0669e783c4fd14e547a276798-pr-277	✅

LinuxServer-CI commented 3 months ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/transmission/4.0.5-r2-pkg-9e1fd792-dev-464d96ef8f86bc4c47e11274f9e0520a91675436-pr-277/index.html https://ci-tests.linuxserver.io/lspipepr/transmission/4.0.5-r2-pkg-9e1fd792-dev-464d96ef8f86bc4c47e11274f9e0520a91675436-pr-277/shellcheck-result.xml	Tag	Passed
amd64-4.0.5-r2-pkg-9e1fd792-dev-464d96ef8f86bc4c47e11274f9e0520a91675436-pr-277	✅
arm64v8-4.0.5-r2-pkg-9e1fd792-dev-464d96ef8f86bc4c47e11274f9e0520a91675436-pr-277	✅

LinuxServer-CI commented 1 month ago

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

LinuxServer-CI commented 1 month ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/transmission/4.0.6-r0-pkg-a7f0831e-dev-2ccc4b8ba7cc5ebcb191e6b225d799e4253629b9-pr-277/index.html https://ci-tests.linuxserver.io/lspipepr/transmission/4.0.6-r0-pkg-a7f0831e-dev-2ccc4b8ba7cc5ebcb191e6b225d799e4253629b9-pr-277/shellcheck-result.xml	Tag	Passed
amd64-4.0.6-r0-pkg-a7f0831e-dev-2ccc4b8ba7cc5ebcb191e6b225d799e4253629b9-pr-277	✅
arm64v8-4.0.6-r0-pkg-a7f0831e-dev-2ccc4b8ba7cc5ebcb191e6b225d799e4253629b9-pr-277	✅

LinuxServer-CI commented 3 weeks ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/transmission/4.0.6-r0-pkg-fbe20213-dev-a4c785cada1ec31094c6ae91dd7acd245f874b4a-pr-277/index.html https://ci-tests.linuxserver.io/lspipepr/transmission/4.0.6-r0-pkg-fbe20213-dev-a4c785cada1ec31094c6ae91dd7acd245f874b4a-pr-277/shellcheck-result.xml	Tag	Passed
amd64-4.0.6-r0-pkg-fbe20213-dev-a4c785cada1ec31094c6ae91dd7acd245f874b4a-pr-277	✅
arm64v8-4.0.6-r0-pkg-fbe20213-dev-a4c785cada1ec31094c6ae91dd7acd245f874b4a-pr-277	✅

linuxserver / docker-transmission