Replace placeholers in properties with `envsubst` - Githubissues

linuxserver / docker-unifi-network-application

GNU General Public License v3.0

551 stars 40 forks source link

Replace placeholers in properties with `envsubst` #72

Open sturman opened 4 months ago

sturman commented 4 months ago

[x] I have read the contributing guideline and understand that I have made the correct modifications

Description:

Use envsubst tool to replace placeholders in system.properties file

Benefits of this PR and context:

less environment variables are required. No need to specify MONGO_AUTHSOURCE, MONGO_TLS etc
possibility to set any MongoDB URL e.g. mongo://user:pass@localhost:27017/my-unifi-db?option=value or for MongoDB Atlasmongodb+srv://unifi-user:password-goes-here@unifi.mongodb.net/unifi?retryWrites=true&w=majority&appName=unifi
possibility to use MongoDB Atlas

Cons: no check if MongoDB is alive.

How Has This Been Tested?

Tested with the following steps on MacOS 14 (Intel):

create free MongoDB Atlas instance.
create a database user with read+write permissions to any DB in the cluster
docker build -t unifi .
docker run --name unifi -p 8443:8443 -e MONGO_URI="mongodb+srv://unifi:password@unifi.mongodb.net/unifi?retryWrites=true&w=majority&appName=unifi" -e STAT_MONGO_URI="mongodb+srv://unifi:password@unifi.mongodb.net/unifi-stats?retryWrites=true&w=majority&appName=unifi" -e MONGO_DBNAME=unifi unifi
open https://0.0.0.0:8443/setup/ in browser
check if both unifi and unifi_stat DBs are created in MongoDB cluster

Source / References:

LinuxServer-CI commented 4 months ago

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-unifi-network-application:8.0.28-pkg-aabd36c7-dev-3be04fb26202945d1944776df234367dadb9843e-pr-72

LinuxServer-CI commented 4 months ago

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-unifi-network-application:8.0.28-pkg-aabd36c7-dev-27594b95a8141a912c1b3832c6262cf273f2b0e4-pr-72

LinuxServer-CI commented 3 months ago

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-unifi-network-application:8.1.113-pkg-f2d4d5b2-dev-41b367182a15e42562f68e375adabc34d356c30c-pr-72

LinuxServer-CI commented 3 months ago

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-unifi-network-application:8.1.113-pkg-f2d4d5b2-dev-1a538030bef5f675b12fffe175c4e2e51f9b1275-pr-72

LinuxServer-CI commented 2 months ago

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-unifi-network-application:8.1.113-pkg-6d1565cd-dev-73b5e6e516ef7efb5afb31619160b095f24eab7d-pr-72

LinuxServer-CI commented 2 months ago

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-unifi-network-application:8.1.113-pkg-5794ab45-dev-f1d258be6cdb84ce3c2697313f4f39dc125366fd-pr-72

LinuxServer-CI commented 1 month ago

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-unifi-network-application:8.1.127-pkg-4c41fbf8-dev-9f8030f07a5da87034e818fd94354ac1bd979183-pr-72

LinuxServer-CI commented 1 month ago

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-unifi-network-application:8.1.127-pkg-45c5b9a8-dev-6c66615f28a83a0905727730795151a37e43bf75-pr-72

LinuxServer-CI commented 1 month ago

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-unifi-network-application:8.1.127-pkg-45c5b9a8-dev-96d3003d43e18732af28a5df9c6a1c99b842fff6-pr-72

LinuxServer-CI commented 3 weeks ago

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-unifi-network-application:8.2.93-pkg-8a06939b-dev-4ea124f871718776de8daff371f144a4c6fb9ab5-pr-72

LinuxServer-CI commented 1 week ago

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-unifi-network-application:8.2.93-pkg-a3865b8a-dev-193fd99ab294de94ecf11abd2595240dd91eee8c-pr-72