linuxserver / docker-webtop

Ubuntu, Alpine, Arch, and Fedora based Webtop images, Linux in a web browser supporting popular desktop environments.
GNU General Public License v3.0
1.77k stars 175 forks source link

[BUG] MODs not working while deployed on KASM #173

Closed kurotorakun closed 1 year ago

kurotorakun commented 1 year ago

Is there an existing issue for this?

Current Behavior

Details of current implementation:
Kasm version 1.13
Kasm deployment type on host (no docker)
Webtop version used webtop:ubuntu-xfce

Docker Run Config Override:

{ 
# <redacted> ...
  "environment": {
    "DOCKER_MODS": "linuxserver/mods:universal-package-install",
    "INSTALL_PACKAGES": "rsync"
  }
} 

With this configuration, the webtop is deployed but "rsync" package is not installed.

Expected Behavior

With above configuration, the expected behaviour should be webtop with rsync package installed.

Steps To Reproduce

  1. Install kasm on host
  2. Keep default configuration
  3. Add Linuxserver repository on Workspace Registry
  4. Add "ubuntu xfce" workspace
  5. Modify added workspace section "Docker Run Config Override" to include the environment variables declaration on first section.
  6. Execute workspace "ubuntu xfce"
  7. Open terminal
  8. try to use "rsync" or "type rsync"

Environment

- OS: Ubuntu 22.04
- How docker service was installed: installed following official guide
- Kasm version: 1.13
- Kasm deployment type: on host (no docker)
- Webtop version used: webtop:ubuntu-xfce

CPU architecture

x86-64

Docker creation

Docker container creation is handled by kasm.

Container logs

reviewed logs but they are contaminated with a lot of kasm "noise".
If guided, I can try to provide as much info as possible.
github-actions[bot] commented 1 year ago

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

thelamer commented 1 year ago

When running in Kasm mode these images do not follow lsio init there is a custom init script it uses: https://github.com/linuxserver/docker-baseimage-kasmvnc/blob/master/root/kasminit

The container is started in user mode and just runs through this bash logic in Kasm mode. So essentially what you are trying to do is not possible, you would want to modify /kasminit inside the container to install packages with sudo.

kurotorakun commented 1 year ago

Hi @thelamer , thanks for the answer! I was pretty sure that it was not a bug, that it was more related to the behavior of the image.

I'm closing the issue.