Fix a readme typos - Githubissues

linuxserver / docker-webtop

Ubuntu, Alpine, Arch, and Fedora based Webtop images, Linux in a web browser supporting popular desktop environments.

GNU General Public License v3.0

1.97k stars 205 forks source link

Fix a readme typos #257

Closed ZeonXr closed 3 months ago

ZeonXr commented 3 months ago

[x] I have read the contributing guideline and understand that I have made the correct modifications

Description:

Modify the incorrect package name "font-noto-cjk" to "fonts-noto-cjk"

Benefits of this PR and context:

How Has This Been Tested?

Source / References:

aptalca commented 3 months ago

Thanks for the PR, but the name is correct: https://pkgs.alpinelinux.org/package/v3.20/community/x86_64/font-noto-cjk

LinuxServer-CI commented 3 months ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/webtop/c1365d22-pkg-c1365d22-dev-cf43b5bd57ee9743ba3f4f9419d992e46de6dc80-pr-257/index.html https://ci-tests.linuxserver.io/lspipepr/webtop/c1365d22-pkg-c1365d22-dev-cf43b5bd57ee9743ba3f4f9419d992e46de6dc80-pr-257/shellcheck-result.xml	Tag	Passed
amd64-c1365d22-pkg-c1365d22-dev-cf43b5bd57ee9743ba3f4f9419d992e46de6dc80-pr-257	✅
arm64v8-c1365d22-pkg-c1365d22-dev-cf43b5bd57ee9743ba3f4f9419d992e46de6dc80-pr-257	✅

ZeonXr commented 3 months ago

Thanks for the PR, but the name is correct: https://pkgs.alpinelinux.org/package/v3.20/community/x86_64/font-noto-cjk

I use the debian-kde tag image and I need to pass the "INSTALL_PACKAGES=fonts-noto-cjk" environment variable to render cjk fonts correctly. However I just tried alpine-kde and "font-noto-cjk" works fine.

aptalca commented 3 months ago

Different distros have different package names. What we provide is an example for the alpine base: https://github.com/linuxserver/docker-webtop/blob/master/readme-vars.yml#L133 To install cjk fonts on startup as an example pass the environment variables (Alpine base):