search

linuxserver / docker-wireguard

GNU General Public License v3.0
2.9k stars 360 forks source link

[BUG] Setting SERVER_ALLOWEDIPS_PEER_ does not recreate configs #342

Closed rwrnet closed 2 months ago

rwrnet commented 2 months ago

Is there an existing issue for this?

Current Behavior

If you set the ENV SERVER_ALLOWEDIPSPEER... peer configs are not recreated.

Log also states: **** No changes to parameters. Existing configs are used. ****

This is due to: https://github.com/linuxserver/docker-wireguard/blob/095f857aca17254b99947eb24b88d237e8977693/root/etc/s6-overlay/s6-rc.d/init-wireguard-confs/run#L178 not checking for changes on the SERVER_ALLOWEDIPS_PEER Envs.

Expected Behavior

If one adds a SERVER_ALLOWEDIPSPEER... config is being recreated.

Steps To Reproduce

  1. start a fresh server config
  2. add SERVER_ALLOWEDIPSPEER... for one of the peers
  3. recreate pod
  4. check for allowedip config added to wg0.conf

Environment

- OS: Ubuntu 24.04
- How docker service was installed: via apt install docker-ce

CPU architecture

x86-64

Docker creation

It should be reproducible with every config. Happy to provide my anonymized specific one, in case it is needed.

Container logs

**** Server mode is selected ****
**** No changes to parameters. Existing configs are used. ****
github-actions[bot] commented 2 months ago

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

rwrnet commented 2 months ago

Just realized, that the documentation states this explicitely. Closing issue.