linuxserver / emulatorjs

Self hosted web based retro emulation front end with rom and art management.
379 stars 26 forks source link

Custom Gameboy Advance touch layout #135

Closed 8bitDesigner closed 1 month ago

8bitDesigner commented 4 months ago

Hi there, and thanks for putting together this very cool version of EmulatorJS! I love my old-school GBA, and I'd love to add a cleaner version of the touchpad layout, and looking at touchpad.js it seems like an easy enough fix.

If I were to open up a PR for this change, is there any JS hijinks I need to go through (Webpack or similar build step), or does this project use vanilla JS?

thelamer commented 4 months ago

No it's all plain and the minified external deps are all stored in repo. If you make a new layout make sure to have it get detected here as well: https://github.com/linuxserver/emulatorjs/blob/master/frontend/js/index.js#L195-L202

LinuxServer-CI commented 3 months ago

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 3 weeks ago

This issue is locked due to inactivity