Add emby proxy improvements

[iSnackyCracky]

---

• [x] I have read the contributing guideline and understand that I have made the correct modifications

---

Description

After struggling with emby playback issues on Android devices (using the Android Emby app) for a long time, it seems I finally found the solution in an older thread on the emby forums. My issue wasn't exactly the same, since Android playback basically didn't work at all for higher quality (and therefore larger) files. After starting playback, the server completely stops responding due to high cpu load caused by iowait. (Unfortunately I wasn't able to find out by what exactly this is/was caused.)

Implementing the proxy_buffering off; directive instantly solved this issue.

Also implemented some other recommended directives for using nginx with emby.

Benefits of this PR and context

Fixes issues with emby playback on Android devices.

How Has This Been Tested?

Tryed to play movie on an Android device using the existing emby sample config. -> Doesn't work. Add proxy_buffering off; directive and restart swag container. Try to play the same movie again. -> Works as expected.

The playback issues have been solved by using only the proxy_buffering off; directive. The other directives were added mainly because they are recommended in multiple threads on the emby forums. I did not verify if they have any noticable impact whatsoever.

Source / References

Recommended NGINX config for emby by pir8radio in the emby forums: https://emby.media/community/index.php?/topic/93074-how-to-emby-with-nginx-with-windows-specific-tips-and-csp-options/ Emby forums thread mentioning a similar Android playback issue that lead to the proxy_buffering off; directive: https://emby.media/community/index.php?/topic/84919-reverse-proxy-issues-after-updating-to-4420/

[aptalca]

Thanks for the PR, but please refrain from adding unnecessary settings here just because someone else recommended on a forum post. A lot of those are set in various nginx confs in SWAG already.

Turning proxy buffering off here is appropriate, though.

[iSnackyCracky]

Yeah, thats what I found for most of the other recommended settings - which is why I didn't add any others. However gzip on; is commented out in the nginx.conf/nginx.conf.sample while gzip_vary on; is still set (which only has any effect, if gzip, gzip_static or gunzip are enabled).

I think there should be little reason not to include an appropriate gzip config. But I understand that there might be some edge cases where it's not desired to use a little more cpu power for compression. Maybe we could add a comment that these directives can be removed or make them "optional" (i.e. comment it out with a notice, just like with including authentication configs)?

I've removed the tcp_nodelay on; directive as that should indeed be enabled by default in nginx. Also removed the gzip_buffers directive as this uses one memory page by default (4k/8k depending on platform).

[iSnackyCracky]

Just to add to this, the settings aren't "just recommended by someone else on a forum post", but instead linked to by the emby forum admins in pretty much every thread mentioning any issues regarding an nginx reverse-proxy setup with emby. ;)

[github-actions[bot]]

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

[github-actions[bot]]

This pull request is locked due to inactivity