search

linuxserver / reverse-proxy-confs

These confs are pulled into our SWAG image: https://github.com/linuxserver/docker-swag
GNU General Public License v3.0
1.33k stars 300 forks source link

Update vaultwarden.subdomain.conf.sample #587

Closed revilo951 closed 1 year ago

revilo951 commented 1 year ago

Adds header upgrades needed for websockets to work properly.

linuxserver.io

Description

Websockets not working correctly using the current template, adding the header upgrades solves that.

Benefits of this PR and context

Working websockets is very handy :)

How Has This Been Tested?

Tested Vaultwarden functions before and after changes, no issues present, websockets working correctly after changes.

Running vaultwarden/server and linuxserver/swag in docker on Ubuntu Server 20.04.

No other areas affected as far as I am able to tell.

Source / References

Roxedus commented 1 year ago

Websockets works OOTB with swag, thanks to this default setting https://github.com/linuxserver/docker-swag/blob/master/root/defaults/nginx/proxy.conf.sample#L26. Ensure that your configs are up to date, as your startup log will tell you.

revilo951 commented 1 year ago

My bad, I missed that.

Thanks for setting me straight.

nemchik commented 1 year ago

Fun story, websockets now work on port 80 as of vaultwarden 1.29, so we can actually update the config to replace the port for that. They have kept port 3012 as a fallback for the moment, so nothing is currently broken.