search

linuxserver / reverse-proxy-confs

These confs are pulled into our SWAG image: https://github.com/linuxserver/docker-swag
GNU General Public License v3.0
1.33k stars 300 forks source link

Update komga.subdomain.conf.sample - updated the port to 25600 from 8080 #607

Closed Simon-CR closed 11 months ago

Simon-CR commented 1 year ago

2023/09/05

linuxserver.io

docker has recently updated the port to 25600 from 8080

allows new deployment to work without end user having to modify the sample file manually

How Has This Been Tested?

made the change on the file manually in my swag deployment without issues

Source / References

in the breaking changes: https://komga.org/blog/prepare-v1/

drizuid commented 1 year ago

i have an issue with this PR, this is a breaking change for anyone not on v1+. IMO for a period of time, it might be better to simply have 2, one for komga and one for komgav1.. i think this is ugly, so my alternative thought is that these details be expressed in the top comments section and port is NOT changed until v1 is the current stable for a certain period of time, TBD.

Simon-CR commented 1 year ago

i have an issue with this PR, this is a breaking change for anyone not on v1+. IMO for a period of time, it might be better to simply have 2, one for komga and one for komgav1.. i think this is ugly, so my alternative thought is that these details be expressed in the top comments section and port is NOT changed until v1 is the current stable for a certain period of time, TBD.

so my current version of this docker image is 1.3.1. this change has been put in production since [1.0.0] released on (2023-06-28). I think 2 months + is good enough to be considered "stable" as far as that change is concerned. I'll leave that to you to decide.

anyone using docker and keeping their images somewhat up to date will be on the new port.

drizuid commented 1 year ago

anyone using docker and keeping their images somewhat up to date will be on the new port.

did the dev end of life/end of support the old version (pre v1.0.0)?

Simon-CR commented 12 months ago

anyone using docker and keeping their images somewhat up to date will be on the new port.

did the dev end of life/end of support the old version (pre v1.0.0)?

dockerhub goes as far back as the 0.1.0 version 4 years ago. Github goes back 12 months ago in the tagged version 0.157.2.

not sure if there's an actual lifecycle process to have version end of life/support.

My view is that the breaking changes were announced prior to version 1 being released by the komga dev team in advance, I'm of the opinion that swag should follow the same.

Most people who have been using swag will know how to fix the port after updating komga. Anyone who's deploying a net new swag/docker environment shouldn't have to reconfigure things to get going. again, just my opinion.

drizuid commented 12 months ago

@aptalca i'll leave it up to you, i'm not sure if we have precedent for this situation or not