search

linuxserver / reverse-proxy-confs

These confs are pulled into our SWAG image: https://github.com/linuxserver/docker-swag
GNU General Public License v3.0
1.33k stars 300 forks source link

[FEAT] [FEAT] include /config/nginx/custom-confs/*.conf #616

Closed quorn23 closed 6 months ago

quorn23 commented 10 months ago

Is this a new feature request?

Wanted change

Addition of include /config/nginx/custom-confs/*.conf in the provided proxy confs.

Reason for change

Currently if a proxy config gets updated and Swag notifies on start up, there is no quick way to update proxy confs with custom config added. Simply changing the date in the header is not really a solution, as the configs should be kept up to date with other changes/updates in Swag.

Introducing the ability to have custom confs included in the server blocks by default would allow to update the proxy confs detached from any custom additions.

Proposed code change

Add a /nginx/custom-confs folder to swag Add include /config/nginx/custom-confs/*.conf to the server blocks of the proxy confs provided

LinuxServer-CI commented 9 months ago

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

quorn23 commented 9 months ago

Happily provide more feedback if needed

nemchik commented 9 months ago

Could you give a more detailed example of what you're describing?

I don't think we'll make a change like this, but could at least discuss how you might be able to come close with your own configurations in the easiest way possible

LinuxServer-CI commented 8 months ago

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 5 months ago

This issue is locked due to inactivity