search

linuxserver / reverse-proxy-confs

These confs are pulled into our SWAG image: https://github.com/linuxserver/docker-swag
GNU General Public License v3.0
1.33k stars 300 forks source link

update bitwarden/vaultwarden templates #624

Closed nemchik closed 9 months ago

nemchik commented 9 months ago

Both templates were written for vaultwarden originally. Setting WEBSOCKET_ENABLED is no longer required (and it's actually encouraged NOT to). The default port (80) serves everything needed now.

These changes were made available with https://github.com/dani-garcia/vaultwarden/releases/tag/1.29.0 and port 3012 is fully deprecated in https://github.com/dani-garcia/vaultwarden/releases/tag/1.30.0

Closes https://github.com/linuxserver/reverse-proxy-confs/issues/623

Spunkie commented 8 months ago

I'm a little confused here on the history of this PR and commits, because the code here that got merged shows a default port of 8080 instead of 80.

In fact if I go to the commit history for the vaultwarden.subdomain.conf.sample file, it shows in the latest commit (ddcc002) the ports being changed to 8080.

But the ports are still 80 if I actually go to the latest version on master: https://github.com/linuxserver/reverse-proxy-confs/blob/master/vaultwarden.subdomain.conf.sample

thespad commented 8 months ago

Because you've misread it. The port was changed in bitwarden.subdomain.conf.sample, not vaultwarden.subdomain.conf.sample

Spunkie commented 8 months ago

Ah 🤦, yea I see now. Thanks @thespa.