linuxserver / reverse-proxy-confs

These confs are pulled into our SWAG image: https://github.com/linuxserver/docker-swag
GNU General Public License v3.0
1.35k stars 300 forks source link

[FEAT] Disable nginx proxy_buffering on emby and jellyfin confs #641

Closed oregonpillow closed 6 months ago

oregonpillow commented 9 months ago

Is this a new feature request?

Wanted change

Disable nginx proxy buffering proxy_buffering off; within emby + jellyfin proxy confs

Ref: http://nginx.org/en/docs/http/ngx_http_proxy_module.html#proxy_buffering

Reason for change

nginx proxy_buffering is generally best turned off for real time streaming applications. Currently the plex conf has it already disabled, but not for emby + jellyfin. Is this something that should also be done for emby + jellyfin?

See here for article summarizing general use cases for enabling/disabling proxy buffering

Proposed code change

example to emby conf:

server {
    listen 443 ssl http2;
    listen [::]:443 ssl http2;

    server_name emby.*;

    include /config/nginx/ssl.conf;

    client_max_body_size 0;
    proxy_buffering off;                 # <------ proposed change

    location / {
        include /config/nginx/proxy.conf;
        include /config/nginx/resolver.conf;
        set $upstream_app emby;
        set $upstream_port 8096;
        set $upstream_proto http;
        proxy_pass $upstream_proto://$upstream_app:$upstream_port;

        proxy_set_header Range $http_range;
        proxy_set_header If-Range $http_if_range;
    }
}
LinuxServer-CI commented 8 months ago

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 5 months ago

This issue is locked due to inactivity