linuxserver / reverse-proxy-confs

These confs are pulled into our SWAG image: https://github.com/linuxserver/docker-swag
GNU General Public License v3.0
1.29k stars 296 forks source link

Nextcloud: update WebDAV URL redirects for subfolder #673

Open h9419 opened 2 months ago

h9419 commented 2 months ago

linuxserver.io



Description

There's existing redirect from /.well-known/carddav and /.well-known/caldav to /nextcloud/remote.php/dav/.

However, in Nextcloud version 29, it will check for /nextcloud/.well-known/carddav which Nextcloud will then resolve to /remote.php/dav/ regardless of overwritewebroot config and will not reach the Nextcloud endpoint.

Benefits of this PR and context

Removes a warning in Nextcloud's "Security & setup warnings" page

How Has This Been Tested?

Removes the warning on my configuration with default lscr.io/linuxserver/swag:2.10.0 and lscr.io/linuxserver/nextcloud:29.0.0

Source / References

LinuxServer-CI commented 1 month ago

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

h9419 commented 1 month ago

This is still a nice-to-have PR

As detailed in https://github.com/nextcloud/server/issues/45033#issuecomment-2077737758 and https://github.com/nextcloud/server/issues/45033#issuecomment-2090125119, Nextcloud 29 starts performing the WebDAV verifications with overwrite.cli.url which is advised to be the same as the URL in which Nextcloud is accessed through

As such, yourhost.com/subfolder/.well-known/carddav will be queried.

I have a question for contributors such as @aptalca, I am just not sure what needs to be done to get this approved

LinuxServer-CI commented 2 weeks ago

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.