search

linuxsoftware / ls.joyous

A calendar application for Wagtail
BSD 3-Clause "New" or "Revised" License
74 stars 35 forks source link

Version 1.4.0 incompatible with holidays v0.13 #44

Closed tbock closed 2 years ago

tbock commented 2 years ago

When updating a project I ran into the below error. It seems to come from a compatibility issue with holidays v0.13. When holding holidays to 0.12 or 0.11the error went away.

File "/usr/local/lib/python3.8/site-packages/ls/joyous/models/init.py", line 12, in from .recurring_events import RecurringEventPage File "/usr/local/lib/python3.8/site-packages/ls/joyous/models/recurring_events.py", line 40, in from ..holidays import Holidays File "/usr/local/lib/python3.8/site-packages/ls/joyous/holidays/init.py", line 8, in from .parser import parseHolidays File "/usr/local/lib/python3.8/site-packages/ls/joyous/holidays/parser.py", line 21, in _PYTHON_HOLIDAYS_MAP = _createMap(list(python_holidays.dict.items())) File "/usr/local/lib/python3.8/site-packages/ls/joyous/holidays/parser.py", line 17, in _createMap obj = cls() TypeError: init() missing 2 required positional arguments: 'h1' and 'h2'

Python 3.8 Django 3.1 ls.joyous 1.4.0 wagtail 2.12

Eng-Ahmad-Almohammad commented 2 years ago

I am facing the same issue.

Mohammad-Abdul-Ghafour commented 2 years ago

Me too facing same issue.

bradrice commented 2 years ago

I just tried installing and am getting this error as well. Mine is after a new installation, not a migrate from previous version.

paperreduction commented 2 years ago

Pinning the install version of python-holidays to 0.12 would fix the issue. I'm not sure why the dependencies aren't already pinned.

I've fixed the problem and pinned the version. Please see attached PR for your review.

bradrice commented 2 years ago

I tried installing again and got holidays==0.13. But now that I know, I downgraded. I'm assuming the change still isn't in master.

paperreduction commented 2 years ago

@bradrice No, it doesn't look like my PR has had any action on it. But pinning the older version of holidays should be a good fix for now. Details on the breaking changes in Holidays v0.13 are in the comments on the PR. You'll see it was a change to the imports in holidays that broke joyous, not a feature/functionality change.

linuxsoftware commented 2 years ago

Thanks to @paperreduction for the fix.