search

linuxstb / pidvbip

tvheadend client for the Raspberry Pi
http://www.pidvbip.org
GNU General Public License v2.0
53 stars 22 forks source link

OSD Channellist #25

Closed eindano closed 11 years ago

eindano commented 11 years ago

OSD channellist. Displays a channellist and current/next title of the current selected item in the list.

Keys: 'c' - display channellist / select channel 'd' - down 'u' - up 'p' - prev page 'n' - next page

linuxstb commented 11 years ago

Thanks. I'll try and test it later tonight (currently working on something else).

My first comment from reading the code though is whether you could move the 'c' key handling into the osd_process_key function? That would seem a better place for it now.

eindano commented 11 years ago

Yes, that would be much better and cleaner.

linuxstb commented 11 years ago

I've now had chance to test this a little and have noticed one bug - the time no longer updates on the original info screen.

I think this is due to the line "if (now != osd->last_now) {" being reverted back to "if (now >= osd->last_now + 60) {" in osd_update().

eindano commented 11 years ago

Sorry! I missed to clean-up the osd_update function after some performence testing. Anyway, from the beginning I had the time on the OSD channellist but it was kind of a performance killer to do an update every second then scrolling in the channellist.

Maybe the clock shouldn't display seconds, only hour:minute?