search

linuxwacom / input-wacom

Linux kernel driver for Wacom devices
GNU General Public License v2.0
611 stars 58 forks source link

HID: wacom: Remove AES power_supply after extended inactivity #404

Closed flying-elephant closed 8 months ago

flying-elephant commented 8 months ago

Even if a user does not use their AES pen for an extended period, the battery power supply attributes continue to exist. This results in the desktop showing battery status for a pen that is no longer in use and which may in fact be in a different state (e.g. the user may be charging the pen). To avoid confusion and ensure userspace has an accurate view of the battery state, this patch automatically removes the power_supply after 30 minutes of inactivity.

Signed-off-by: Tatsunosuke Tobita tatsunosuke.tobita@wacom.com Reviewed-by: Jason Gerecke Jason.Gerecke@wacom.com Reviewed-by: Aaron Skomra aaron.skomra@wacom.com Reviewed-by: Josh Dickens joshua.dickens@wacom.com Link: https://lore.kernel.org/r/20231114235729.6867-1-tatsunosuke.wacom@gmail.com Signed-off-by: Benjamin Tissoires bentiss@kernel.org [tatsunosuke.tobita@wacom.com: Imported into input-wacom (fd2a9b29dc9c)] Signed-off-by: Tatsunosuke Tobita tatsunosuke.tobita@wacom.com

flying-elephant commented 8 months ago

I fixed the very last line of the commit message since this change is not a fix of any issue, but improvement and elaboration for the driver.