search

linuxwacom / xf86-input-wacom

X.Org driver for Wacom devices
361 stars 45 forks source link

Correct various build warnings, mostly related to signed/unsigned #254

Closed jigpu closed 2 years ago

jigpu commented 2 years ago

This started out with a desire to remove the -Wno-error=sign-compare from our CFLAGS, but grew a little larger in scope to also include fixes for other warnings, e.g. from the scan-build static analyzer.

@whot I notice you added -Wno-error=missing-field-initializers recently but I don't see any build warnings about missing initializers... Is there a specific configuration that triggers it that I'm overlooking?

whot commented 2 years ago

Is there a specific configuration that triggers it that I'm overlooking?

I failed in the CI pipelines, iirc it was clang with -Werror

jigpu commented 2 years ago

Running into other errors in the Clang path as well. Guess I'll be making a few more runs of whack-a-mole.