search

linuxwacom / xf86-input-wacom

X.Org driver for Wacom devices
356 stars 46 forks source link

Test artpen rotation #265

Closed whot closed 2 years ago

whot commented 2 years ago

cc @skomra

A few useful cleanups, then a few necessary cleanups, and finally the small change to test artpen rotation comes through as expected.

Confusingly, artpen rotation is not sent through the rotation axis but through the "wheel" axis. rotation is only for cursor/puck rotation. The artpen physical rotation in ABS_Z is handled by the driver as wheel because the X11 valuator is shared with the airbrush wheel.

skomra commented 2 years ago

Hi Peter,

Thanks for all the work you've done here. These patches look great and I understand better what's going on with the pytests.

Which recording are you referring to in df6723ff149e589bb147d44bb0bae78054f849a4?

Reviewed-by: Aaron Skomra aaron.skomra@wacom.com

whot commented 2 years ago

Which recording are you referring to in https://github.com/linuxwacom/xf86-input-wacom/commit/df6723ff149e589bb147d44bb0bae78054f849a4?

Not an actual problem at the timeline of the patch but without it the last commit (07b857d9921e3f3ca82ed8d94503799e7c4764f3) won't work. The VID is assigned to the pth660 product id (our test device recording) and then the IsArtPen checks don't work because they check for the wacom VID.

Thanks for the review!