search

linuxwacom / xf86-input-wacom

X.Org driver for Wacom devices
361 stars 45 forks source link

Filter initial pressure #280

Closed Pinglinux closed 2 years ago

Pinglinux commented 2 years ago

Best to liberally sprinkle comments into the test to explain what we're expecting and why.

Explain my thoughts in one block before getting into @whot's comments in detail.

Due to the introduction of the filter, we need to add at least 2 new unit test cases to cover the corner cases: min_pressure falls below min_pressure_threshold when already in proximity and min_pressure is less than min_pressure_threshold when first time in proximity. One of your suggestions may require another unit test case to cover.

Pinglinux commented 2 years ago

After investigating the relevant code, we think the case has been covered by setPressureButton.