Closed whot closed 1 year ago
There are some minor issues, I fixed them in my branch, you can just cherry-pick commit 07581618a0d26a8135cde4fd930c3eb432d62461. Otherwise, LGTM, I've got this (modified) version built and it seems to be working correctly.
Thanks for testing, let's get this merged, we can fix any remaining issues with follow-up patches.
Awesome! Thank you very much for your cooperation and help, this is my first proper contribution to open source and I'm glad to have it finally done!
This is the remaining patchset from #222 squashed together, after #297 and #296. No changes other than a whitespace fix and some comment typo.
@Greenscreener, can you give this one a test please to make sure nothing broke? Thanks