search

linuxwacom / xf86-input-wacom

X.Org driver for Wacom devices
356 stars 45 forks source link

generate full xorg config with --xconf #331

Closed petaflot closed 5 months ago

petaflot commented 8 months ago

quit disappointed that --xconf flag does not generate the full config[^1], including values shown below and specifically idevnane and devpath

Section "InputDevice"
  Identifier "idevname"
  Driver "wacom"
  Option "Device"   "devpath"
  ...
EndSection

furthermore, [^1] specifies quite a number of options that are absent from xsetwacom -x output. is it on purpose?

jigpu commented 8 months ago

It might be useful to generate a more-complete configuration for easier copy/paste, but that can be a little tricky. The value of Identifier must be unique but also ideally human-readable, and a fixed Device path is very likely to cause problems (there's a reason Xorg has moved away from static xorg.conf sections to instead use xorg.conf.d snippets).

As for missing options, your man page link is quite out of date, so some of those options might not even work on a modern driver. There are also some options that can /only/ be set through a configuration snippet (meaning xsetwacom isn't aware of them) and some options that can /only/ be set through xsetwacom (meaning the configuration snippet can't apply them). The difference is largely due to one or the other being overlooked at the time of implementation.

I think all of these problems are solveable (both the tricky ones and the overlooked implementations), but I don't think there's any interest from the dev team in improving this rarely-used option. Patches are accepted, but we are unlikely to work on this ourselves...

whot commented 5 months ago

Going to add an extra note here: adding all possible options with their default values is IMO bad practice and increases the workload on maintainers if something goes wrong. First, this means that any upstream default option changes never make it through to the user without them updating the config file. We don't change defaults very often so when we do it's usually for good reasons.

Second, unless the user puts the effort in during reporting it can be impossible to say for us which of the 50 options listed in the config file was changed on purpose and which one was just dumped there from some old version of the driver.

Overall, I think our man page is detailed enough that adding the options that matter is largely an exercise in copy/paste, having xsetwacom spit out a config with all options is counterproductive.