Open EladGabay opened 1 year ago
@linvon would you like to take a look? 😊
@linvon would you like to take a look? 😊
Sorry, busy with work, but I will find some time to handle this
Hi, @linvon , let me know if you need any help :)
@linvon gentle ping
Hi @linvon do you think it's going to be merged soon? 🙏
This commit improves encoding by enabling the handling of number of items and buckets exceeding max(uint32). Formerly, the encoding used uint32 for counts, but the filter structure already supported larger values using uint. Until now, the filter partially supported larger datasets, not all the buckets were utilized, note to the change in
generateIndexTagHash
,altIndex
andindexHash
.Now, all references to bucket indices and item counts explicitly use uint64. A new encoding format accommodates larger filter. To distinguish between legacy (up to max(uint32) items) and the new format, a prefix marker is introduced.
Decoding seamlessly supports both formats. The encode method takes a legacy boolean parameter for gradual adoption.