Closed harman28 closed 7 years ago
@harman28 , thank you for being willing to help out!
Regarding your commit/pull request, I don't think you added your changes to the commit.
I know git can be hard to get used to while you're also learning Python but I was learning git not long ago. Soon, it will make sense. This type of practice helps.
This guide from the pandas library is a great model to follow when trying to add to gdeltPyR
. Try to follow these steps (make sure you make a new branch). Commit your changes to the new branch, merge your branch into master (your forked version), see if your tests pass, then send a pull request to us.
Make sure you can still use the library the same way the example say in the README examples.
And it looks like this commit is where you made changes; however, these changes aren't included in your pull request. https://github.com/smweetee/gdeltPyR/commit/faa0420e30e781ce0e57ad9f3170e3453e42a402
@linwoodc3 Not sure what you mean. The commit you've linked to belongs to a different user, @smweetee, not me. And it looks like it's attempting to do something very different.
I'm just looking to add a .gitignore
file. So that all those .pyc
files don't show up in git status
and get accidentally checked into the code.
Oh. I'm mixed up. Will look at it. Sorry.
I ran tests and was met with this:
Let know me if there's anything else you'd like to add.