linwoodc3 / gdeltPyR

Python based framework to retreive Global Database of Events, Language, and Tone (GDELT) version 1.0 and version 2.0 data.
https://linwoodc3.github.io/gdeltPyR/
GNU General Public License v3.0
203 stars 53 forks source link

Adds gitignore file #32

Closed harman28 closed 7 years ago

harman28 commented 7 years ago

I ran tests and was met with this:

$ gdeltPyR (master) > git status
On branch make_utility_methods_private
Untracked files:
  (use "git add <file>..." to include in what will be committed)

    .cache/
    .coverage
    gdelt/__init__.pyc
    gdelt/base.pyc
    gdelt/dateFuncs.pyc
    gdelt/getHeaders.pyc
    gdelt/helpers.pyc
    gdelt/inputChecks.pyc
    gdelt/multipdf.pyc
    gdelt/parallel.pyc
    gdelt/vectorizingFuncs.pyc
    tests/__init__.pyc
    tests/__pycache__/

nothing added to commit but untracked files present (use "git add" to track)

Let know me if there's anything else you'd like to add.

linwoodc3 commented 7 years ago

@harman28 , thank you for being willing to help out!

Regarding your commit/pull request, I don't think you added your changes to the commit.

I know git can be hard to get used to while you're also learning Python but I was learning git not long ago. Soon, it will make sense. This type of practice helps.

This guide from the pandas library is a great model to follow when trying to add to gdeltPyR. Try to follow these steps (make sure you make a new branch). Commit your changes to the new branch, merge your branch into master (your forked version), see if your tests pass, then send a pull request to us.

Make sure you can still use the library the same way the example say in the README examples.

linwoodc3 commented 7 years ago

And it looks like this commit is where you made changes; however, these changes aren't included in your pull request. https://github.com/smweetee/gdeltPyR/commit/faa0420e30e781ce0e57ad9f3170e3453e42a402

harman28 commented 7 years ago

@linwoodc3 Not sure what you mean. The commit you've linked to belongs to a different user, @smweetee, not me. And it looks like it's attempting to do something very different.

I'm just looking to add a .gitignore file. So that all those .pyc files don't show up in git status and get accidentally checked into the code.

linwoodc3 commented 7 years ago

Oh. I'm mixed up. Will look at it. Sorry.