search

linwoodc3 / gdeltPyR

Python based framework to retreive Global Database of Events, Language, and Tone (GDELT) version 1.0 and version 2.0 data.
https://linwoodc3.github.io/gdeltPyR/
GNU General Public License v3.0
203 stars 53 forks source link

Make utility methods private #35

Closed smritigambhir closed 7 years ago

smritigambhir commented 7 years ago

Fixes #31 Travis build trace: https://www.travis-ci.org/smweetee/gdeltPyR/builds/256781931

linwoodc3 commented 7 years ago

Will have time to review tomorrow @smweetee

linwoodc3 commented 7 years ago

Still checking; i got some errors at first. will retry.

smritigambhir commented 7 years ago

Aah. In case it doesn't work, let me know the error you get. Latest travis trace: https://www.travis-ci.org/smweetee/gdeltPyR/builds/256784995

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 51.55% when pulling 96628d4ca457c6b61a5b011d27c23cd15c1894a9 on smweetee:make_util_methods_private into c597bf3d569b12605f7652e599f9b44acd8053b6 on linwoodc3:master.

linwoodc3 commented 7 years ago

@smweetee , I made some other merges before I merged your PR in, but it all passed the test. Thanks for the PR and help!!!

Since you're learning Python, here's some more on private classes/methods, although I know you understand this because you correctly used the single underscore instead of the double underscore.

https://stackoverflow.com/questions/1301346/what-is-the-meaning-of-a-single-and-a-double-underscore-before-an-object-name

Thanks again!

smritigambhir commented 7 years ago

Thanks for the article :) Will check out the PR too.

On Aug 5, 2017 19:03, "Linwood Creekmore" notifications@github.com wrote:

@smweetee https://github.com/smweetee , I made some other merges before I merged your PR in, but it all passed the test. Thanks for the PR and help!!!

Since you're learning Python, here's some more on private classes/methods, although I know you understand this because you correctly used the single underscore instead of the double underscore.

https://stackoverflow.com/questions/1301346/what-is-the- meaning-of-a-single-and-a-double-underscore-before-an-object-name

Thanks again!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/linwoodc3/gdeltPyR/pull/35#issuecomment-320443974, or mute the thread https://github.com/notifications/unsubscribe-auth/AHdcxYo98A7DIhWrX0bCbxCwH07hBlodks5sVG8wgaJpZM4Og2FO .