search

linwoodc3 / gdeltPyR

Python based framework to retreive Global Database of Events, Language, and Tone (GDELT) version 1.0 and version 2.0 data.
https://linwoodc3.github.io/gdeltPyR/
GNU General Public License v3.0
197 stars 52 forks source link

Missing requirements? (pytest-cov, geopandas) #55

Closed reed9999 closed 5 years ago

reed9999 commented 5 years ago

I'm running tests for the first time, and I went through the usual process of pip3 install -r requirements.txt from a virtualenv. It seems like there might be necessary packages that are missing:

pytest-cov

I got some issues with py.test: error: unrecognized arguments: --cov --cov-repo=term-missing which turned out to be a different root cause (system pytest being used). Nevertheless, in troubleshooting I got the impression pytest-cov probably should be installed explicitly. It might just be installed by upgrading to a current python-pytest, not sure.

geopandas

Now that I can run the tests, everything seems to pass except a couple with ModuleNotFoundError: No module named 'geopandas'. I thought maybe geopandas would be installed in requirements_geo.txt but apparently not. It's unclear to me which of the requirements files should install it, or both.

linwoodc3 commented 5 years ago

Thanks @reed9999 . I think I initially left them off because most people will need C dependencies to install geopandas (i.e. it requires GDAL and GEOS).

Thanks for the PR. To get the full environment, I recommend using my instructions on building the environment to test/develop on gdeltPyR.. Using Anaconda for your installs will ALWAYS work better than pip, especially when you have C dependencies.

For help on installing geopandas, see their install page. geopandas uses shapely and fiona which has dependencies. Look up their pages to get those installed, and then geopandas will install fine.

linwoodc3 commented 5 years ago

Very weird, I checked and all of a sudden, four (4) days ago my automated builds started failed. No idea why?

https://travis-ci.org/linwoodc3/gdeltPyR/builds

Looking at your PR now.

linwoodc3 commented 5 years ago

This broke windows; have to revert back and investigate this more.

linwoodc3 commented 5 years ago

The builds for x86 windows are failing now because of https://github.com/conda/conda/issues/7626. I am dropping these tests for Windows until the new conda comes out.

reed9999 commented 5 years ago

Hmm, that is weird. If I'm understanding, there were preexisting issues that broke build 199, which is the Anaconda issue above, and then I'm unclear if my PR broke something. I need to reread that a few times.

So in dropping the tests for Windows, does that mean the PR is now merged in and tests pass again? I know there are a few interacting issues.

linwoodc3 commented 5 years ago

@reed9999 yes. Something about your PR broke all the CI tests. I couldn't figure out why your tests were green and the validation run on the master branch kept failing.

I reworked things last night and everything is passing again.