search

linxihui / NNLM

Nonnegative Linear Models (NNLM) and Nonnegative Matrix Factorization (NMF or NNMF).
Other
76 stars 22 forks source link

CRAN #1

Closed gdkrmr closed 6 years ago

gdkrmr commented 6 years ago

CRAN says that NNLM got archived, are you going to put it back on CRAN?

linxihui commented 6 years ago

Hi Guido,

There was a warning in version 0.4.1 (it was removed from CRAN and archived) and I am fixing it by submitting a version 0.4.2. I don't know exactly how I should do this. Should I fix 0.4.1 by re-submit the same version (0.4.1) or a new version and ignore the warning in version 0.4.1? Is updating a package the same as submitting a new package?

Thanks,

Eric

On Tue, May 8, 2018 at 8:28 AM, Guido Kraemer notifications@github.com wrote:

CRAN says you package got archived, are going to be back on CRAN?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/linxihui/NNLM/issues/1, or mute the thread https://github.com/notifications/unsubscribe-auth/AGi9AjQJhuENQDYx4vZxOzc_YH3YemXkks5twY9igaJpZM4T2jW_ .

gdkrmr commented 6 years ago

I think that simply submitting version 0.4.2 will be fine, just make a comment that you fixed the warnings.

ttriche commented 6 years ago

bump the package version and resubmit. NNLM is fantastic, would be tragic for it to go away.

--t

On Mon, May 21, 2018 at 3:28 PM, Eric Xihui Lin notifications@github.com wrote:

Hi Guido,

There was a warning in version 0.4.1 (it was removed from CRAN and archived) and I am fixing it by submitting a version 0.4.2. I don't know exactly how I should do this. Should I fix 0.4.1 by re-submit the same version (0.4.1) or a new version and ignore the warning in version 0.4.1? Is updating a package the same as submitting a new package?

Thanks,

Eric

On Tue, May 8, 2018 at 8:28 AM, Guido Kraemer notifications@github.com wrote:

CRAN says you package got archived, are going to be back on CRAN?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/linxihui/NNLM/issues/1, or mute the thread https://github.com/notifications/unsubscribe- auth/AGi9AjQJhuENQDYx4vZxOzc_YH3YemXkks5twY9igaJpZM4T2jW_ .

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/linxihui/NNLM/issues/1#issuecomment-390757186, or mute the thread https://github.com/notifications/unsubscribe-auth/AAARIlPZRKO_RQjXCMgPx_4uXf2F5FCGks5t0xVngaJpZM4T2jW_ .

topepo commented 6 years ago

Is there anything that I can do to help get this back on CRAN? If you need some guidance on the submitting process, I'd be happy to help out.

If you haven't done it in a while, I suggest running R CMD check --as-cran on the current version of R and pasting the output in the notes section of the submission.

This is a lot easier if you use the devtools package. It also contains a function that will do a test submission to a server that is much closer to the process that CRAN uses to check packages.

gdkrmr commented 6 years ago

any news, or at least a statement that you will not support this package any more?

linxihui commented 6 years ago

@gdkrmr @topepo I submitted 0.4.2 to CRAN, but it is still complaining the 0.4.1 warning issue. Seems like I have to do a 0.4.1 submission to fix the issue instead of a new version. Do you know anything about it? I don't know what to do exactly. BTW, I am using devtools, just the way of submission/update to CRAN confuses me.

gdkrmr commented 6 years ago

I don't think that this is the case, if the warning is the same as 0.4.1 then you probably did not fix it ;-)

gdkrmr commented 6 years ago

does it give a warning on your own machine?

linxihui commented 6 years ago

@gdkrmr No warning. There is only a NOTE saying the previous version is archived.

linxihui commented 6 years ago

@gdkrmr I was giving a link to confirm the submission of version 0.4.2, and one of the checkboxes is "I have fixed all problems shown on the package check page." But the link shows the building error of previous version (0.4.1).

topepo commented 6 years ago

You should also look at the build_win function in devtools. The package maintainer can submit their package to an internal testing server that CRAN uses to get the most real sense of what might get flagged. It's not perfect but helps a lot. Just don't overwhelm them with submissions.

gdkrmr commented 6 years ago

looking at the warning in your link, it looks like the method did not converge, did you try more iterations?

linxihui commented 6 years ago

@gdkrmr @topepo FYI, the package is now on CRAN again.

ttriche commented 6 years ago

you're a hero

thanks!

--t

On Mon, Jun 18, 2018 at 6:22 PM Eric Xihui Lin notifications@github.com wrote:

@gdkrmr https://github.com/gdkrmr @topepo https://github.com/topepo FYI, the package is now on CRAN again.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/linxihui/NNLM/issues/1#issuecomment-398214223, or mute the thread https://github.com/notifications/unsubscribe-auth/AAARItPRUy0yy02ZnI6rcyOUV6CMnW2kks5t-CgfgaJpZM4T2jW_ .

gdkrmr commented 6 years ago

ok, great!