search

linxingang / sfntly

Automatically exported from code.google.com/p/sfntly
0 stars 0 forks source link

No newline at end of file #3

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
clang warns:

third_party/sfntly/src/sfntly/table/subtable_container_table.h:48:79: warning: 
no newline at end of file [-pedantic,-Wnewline-eof]
#endif  // TYPOGRAPHY_FONT_SFNTLY_SRC_SFNTLY_TABLE_SUBTABLE_CONTAINER_TABLE_H_
                                                                              ^

You should set chromium_code in sfntly's gyp file to enable warnings-as-errors 
for sfntly. It looks mostly clean, and that will make sure you don't regress.

Original issue reported on code.google.com by thakis@chromium.org on 13 Oct 2011 at 9:51

GoogleCodeExporter commented 9 years ago 
The change will be in Chrome after bitmap subsetter is finished (also the gyp 
change).

Original comment by arthur...@google.com on 20 Oct 2011 at 8:31

GoogleCodeExporter commented 9 years ago 
Any news on this? I'm still seeing this in chromium. It's been over a month.

Original comment by thakis@google.com on 21 Nov 2011 at 8:46