search

linyimin0812 / wechaty-puppet-ioscat

Puppet Ios Cat for Wechaty
https://www.npmjs.com/package/wechaty-puppet-ioscat
Apache License 2.0
37 stars 11 forks source link

Implment the required new methods for Puppet #10

Closed huan closed 6 years ago

huan commented 6 years ago

@linyimin-bupt I had just upgrade the puppet dependence to the latest v0.13.

There are several required new Abstract methods in the Puppet class need to be implemented, so please have a look and fix them as well.

Current the CI test will fail, after the fix, it should turn to green again.

Related commit: https://github.com/linyimin-bupt/wechaty-puppet-ioscat/commit/f2339c3fb5ab42c7d39b32476773fe09c382ba4c

linyimin0812 commented 6 years ago

OK

huan commented 6 years ago

You need to read this: https://github.com/Chatie/wechaty-puppet/wiki/Troubleshooting

linyimin0812 commented 6 years ago

I'm sorry, I had other job to finish recently, and had no time to fix the Related issues, I will fix them tomorrow.

huan commented 6 years ago

No problem.

It's no rush and please take it easy.

huan commented 6 years ago

It seems that you had already fixed all those problems.

However, you did not mention this issue in your related commits. It will be good practice to mention the related issue in your commit message so that we can track them more clearly. Hope you can follow this rule in the future.

And because this issue had been solved, could you please close this issue for now?

linyimin0812 commented 6 years ago

OK, Thanks very much.I will notice this, and try to make it better.