Open TheJaredWilcurt opened 9 years ago
+1
+1
In the meantime, I made this. I'm still testing it to ensure it isn't breaking anything but it seems to be working as intended until the extension can include support for GHE installations.
I agree with @TheJaredWilcurt though I think a better regex would be /^https?:\/\/github\..*?\/.*?\/.*?\/wiki/
as this would return true for both public and enterprise GitHub installations. That being said, I believe the real limitation here is in the manifest of the Chrome extension as you have to define on which sites you want the script to run. Though I may be wrong!
+1, though our subdomain contains 'github' it doesn't start with it.
+1
Really the correct answer is to just let people type in the root for their own github server, even if it's just localhost:8080
.
Though, auto-guessing would be cool too.
Hrmmm we never closed this issue... lol
This is done and it's a feature now for anyone who is curious. And you can do exactly that @TheJaredWilcurt; there's an options page that lets you define for which domains you want the extension to run on.
@ccampanale
I just downloaded the extension and tried it on both github and ghe, and neither worked. There's also no options page.
I also am unable to find the options you refer to.
Guys, my bad... I got the extension mixed up; I was thinking this was another one that I contributed to that recently got enterprise support... :-/ This one unfortunately still has no support for enterprises... :( Sorry
You have the github website hardcoded. It would be nice if there was an options page for users to add in custom URLs/domains for this to work on. Many companies have the enterprise version of GitHub and being able to search the wiki at work would be super useful.
If nothing else, you could just add in a regex thing to look for
http(s)://githib.*.com/*/*/wiki